Don't reset the cache twice in DOMServerIntegration tests

We used to do this to simulate testing separate bundles.
But now we actually *do* test bundles. So there is no need for this, as it makes tests slower.

Author: gaearon

packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js

@@ -15,20 +15,11 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationBasic-test.js

@@ -17,20 +17,11 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationContext-test.js

@@ -16,21 +16,12 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   PropTypes = require('prop-types');
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js

@@ -17,20 +17,10 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
   jest.resetModuleRegistry();
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js

@@ -16,21 +16,12 @@ let ReactDOM;
 let ReactDOMServer;
 let ReactTestUtils;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   React = require('react');
   ReactDOM = require('react-dom');
   ReactTestUtils = require('react-dom/test-utils');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationFragment-test.internal.js

@@ -15,22 +15,12 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   require('shared/ReactFeatureFlags').enableReactFragment = true;
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
-  require('shared/ReactFeatureFlags').enableReactFragment = true;
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationReconnecting-test.js

@@ -15,21 +15,12 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
 
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.

packages/react-dom/src/__tests__/ReactDOMServerIntegrationRefs-test.js

@@ -15,20 +15,11 @@ let React;
 let ReactDOM;
 let ReactDOMServer;
 
-// When there is a test that renders on server and then on client and expects a logged
-// error, you want to see the error show up both on server and client. Unfortunately,
-// React refuses to issue the same error twice to avoid clogging up the console.
-// To get around this, we must reload React modules in between server and client render.
 function initModules() {
-  // First, reset the modules to load the client renderer.
+  // Reset warning cache.
   jest.resetModuleRegistry();
   React = require('react');
   ReactDOM = require('react-dom');
-
-  // Now we reset the modules again to load the server renderer.
-  // Resetting is important because we want to avoid any shared state
-  // influencing the tests.
-  jest.resetModuleRegistry();
   ReactDOMServer = require('react-dom/server');
 
   // Make them available to the helpers.