Skip to content

Commit 36ded71

Browse files
committed
Fix nodeName to UPPERCASE in insertStylesheetIntoRoot (#28255)
## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> <img width="518" alt="image" src="https://github.com/facebook/react/assets/18693190/6d12df76-7dae-403b-b486-4940992abe8d"> The condition `node.nodeName === 'link'` is always `false`, because `node.nodeName` is Uppercase in specification. And the condition `node.nodeName === 'LINK'` is unnecessary, because Fizz hoists tags when it's `media` attribute is `"not all"`, whether it is a `link` or a `style` (line 36): https://github.com/facebook/react/blob/18cbcbf783377c5a22277a63ae41af54504502e0/packages/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetExternalRuntime.js#L30-L44 https://github.com/facebook/react/blob/18cbcbf783377c5a22277a63ae41af54504502e0/packages/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetInlineSource.js#L30-L44 DiffTrain build for [b75cc07](b75cc07)
1 parent a2485b7 commit 36ded71

34 files changed

+190
-201
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3d95c43b8967d4dda1ec9a22f0d9ea4999fee8b8
1+
b75cc078c5fda0d57135523a7a2f4e8d1536472f
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3d95c43b8967d4dda1ec9a22f0d9ea4999fee8b8
1+
b75cc078c5fda0d57135523a7a2f4e8d1536472f

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2001,7 +2001,7 @@ __DEV__ &&
20012001
exports.useTransition = function () {
20022002
return resolveDispatcher().useTransition();
20032003
};
2004-
exports.version = "19.0.0-www-classic-3d95c43b-20240913";
2004+
exports.version = "19.0.0-www-classic-b75cc078-20240914";
20052005
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20062006
"function" ===
20072007
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1981,7 +1981,7 @@ __DEV__ &&
19811981
exports.useTransition = function () {
19821982
return resolveDispatcher().useTransition();
19831983
};
1984-
exports.version = "19.0.0-www-modern-3d95c43b-20240913";
1984+
exports.version = "19.0.0-www-modern-b75cc078-20240914";
19851985
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19861986
"function" ===
19871987
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-3d95c43b-20240913";
668+
exports.version = "19.0.0-www-classic-b75cc078-20240914";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-3d95c43b-20240913";
668+
exports.version = "19.0.0-www-modern-b75cc078-20240914";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-3d95c43b-20240913";
672+
exports.version = "19.0.0-www-classic-b75cc078-20240914";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-3d95c43b-20240913";
672+
exports.version = "19.0.0-www-modern-b75cc078-20240914";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17121,11 +17121,11 @@ __DEV__ &&
1712117121
(function () {
1712217122
var internals = {
1712317123
bundleType: 1,
17124-
version: "19.0.0-www-classic-3d95c43b-20240913",
17124+
version: "19.0.0-www-classic-b75cc078-20240914",
1712517125
rendererPackageName: "react-art",
1712617126
currentDispatcherRef: ReactSharedInternals,
1712717127
findFiberByHostInstance: getInstanceFromNode,
17128-
reconcilerVersion: "19.0.0-www-classic-3d95c43b-20240913"
17128+
reconcilerVersion: "19.0.0-www-classic-b75cc078-20240914"
1712917129
};
1713017130
internals.overrideHookState = overrideHookState;
1713117131
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17159,7 +17159,7 @@ __DEV__ &&
1715917159
exports.Shape = Shape;
1716017160
exports.Surface = Surface;
1716117161
exports.Text = Text;
17162-
exports.version = "19.0.0-www-classic-3d95c43b-20240913";
17162+
exports.version = "19.0.0-www-classic-b75cc078-20240914";
1716317163
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1716417164
"function" ===
1716517165
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16567,11 +16567,11 @@ __DEV__ &&
1656716567
(function () {
1656816568
var internals = {
1656916569
bundleType: 1,
16570-
version: "19.0.0-www-modern-3d95c43b-20240913",
16570+
version: "19.0.0-www-modern-b75cc078-20240914",
1657116571
rendererPackageName: "react-art",
1657216572
currentDispatcherRef: ReactSharedInternals,
1657316573
findFiberByHostInstance: getInstanceFromNode,
16574-
reconcilerVersion: "19.0.0-www-modern-3d95c43b-20240913"
16574+
reconcilerVersion: "19.0.0-www-modern-b75cc078-20240914"
1657516575
};
1657616576
internals.overrideHookState = overrideHookState;
1657716577
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16605,7 +16605,7 @@ __DEV__ &&
1660516605
exports.Shape = Shape;
1660616606
exports.Surface = Surface;
1660716607
exports.Text = Text;
16608-
exports.version = "19.0.0-www-modern-3d95c43b-20240913";
16608+
exports.version = "19.0.0-www-modern-b75cc078-20240914";
1660916609
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1661016610
"function" ===
1661116611
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)