[flow] Upgrade Flow to 0.245.2 (#30919)

SamChou19815 · SamChou19815 · commit 12971be8e96b · 2024-09-09T08:51:21.000-07:00
## Summary This PR bumps Flow all the way to the latest 0.245.2. Most of the suppressions comes from Flow v0.239.0's change to include undefined in the return of `Array.pop`. I also enabled `react.custom_jsx_typing=true` and added custom jsx typing to match the old behavior that `React.createElement` is effectively any typed. This is necessary since various builtin components like `React.Fragment` is actually symbol in the React repo instead of `React.AbstractComponent<...>`. It can be made more accurate by customizing the `React$CustomJSXFactory` type, but I will leave it to the React team to decide. ## How did you test this change? `yarn flow` for all the renderers DiffTrain build for commit e210d08.
diff --git a/compiled-rn/VERSION_NATIVE_FB b/compiled-rn/VERSION_NATIVE_FB
@@ -1 +1 @@
-19.0.0-native-fb-727b3615-20240906
+19.0.0-native-fb-e210d081-20240909
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<7986e32cbf9ce62a80c6cdb99f68f4d4>>
+ * @generated SignedSource<<6c3c44625d18e331ccc65c0c55888c8e>>
  */
 
 "use strict";
@@ -15057,11 +15057,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-native-fb-727b3615-20240906",
+        version: "19.0.0-native-fb-e210d081-20240909",
         rendererPackageName: "react-test-renderer",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+        reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -15206,5 +15206,5 @@ __DEV__ &&
             flushSyncWorkAcrossRoots_impl(0, !0));
       }
     };
-    exports.version = "19.0.0-native-fb-727b3615-20240906";
+    exports.version = "19.0.0-native-fb-e210d081-20240909";
   })();
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<737b0c6df35b54b9ca58121c9993e75b>>
+ * @generated SignedSource<<9735780e41887579bc9fb1037b24f3b7>>
  */
 
 "use strict";
@@ -9445,14 +9445,14 @@ function wrapFiber(fiber) {
 }
 var internals$jscomp$inline_1264 = {
   bundleType: 0,
-  version: "19.0.0-native-fb-727b3615-20240906",
+  version: "19.0.0-native-fb-e210d081-20240909",
   rendererPackageName: "react-test-renderer",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function (mockNode) {
     mockNode = nodeToInstanceMap.get(mockNode);
     return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
   },
-  reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+  reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1265 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -9588,4 +9588,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
         flushSyncWorkAcrossRoots_impl(0, !0));
   }
 };
-exports.version = "19.0.0-native-fb-727b3615-20240906";
+exports.version = "19.0.0-native-fb-e210d081-20240909";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<810ece3813f16a4de75fcacac7d7813e>>
+ * @generated SignedSource<<ec7b9fb6d11cd3c4624086736a6b7f10>>
  */
 
 "use strict";
@@ -10033,14 +10033,14 @@ function wrapFiber(fiber) {
 }
 var internals$jscomp$inline_1139 = {
   bundleType: 0,
-  version: "19.0.0-native-fb-727b3615-20240906",
+  version: "19.0.0-native-fb-e210d081-20240909",
   rendererPackageName: "react-test-renderer",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function (mockNode) {
     mockNode = nodeToInstanceMap.get(mockNode);
     return void 0 !== mockNode ? mockNode.internalInstanceHandle : null;
   },
-  reconcilerVersion: "19.0.0-native-fb-727b3615-20240906",
+  reconcilerVersion: "19.0.0-native-fb-e210d081-20240909",
   getLaneLabelMap: function () {
     for (
       var map = new Map(), lane = 1, index$138 = 0;
@@ -10191,4 +10191,4 @@ exports.unstable_batchedUpdates = function (fn, a) {
         flushSyncWorkAcrossRoots_impl(0, !0));
   }
 };
-exports.version = "19.0.0-native-fb-727b3615-20240906";
+exports.version = "19.0.0-native-fb-e210d081-20240909";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<7891b4d6325e775d1f22d4b9936dd94c>>
+ * @generated SignedSource<<f1d66600931075ca6b105473c9d7b292>>
  */
 
 "use strict";
@@ -1705,7 +1705,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.0.0-native-fb-727b3615-20240906";
+    exports.version = "19.0.0-native-fb-e210d081-20240909";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<f3fc58abefc1049be1a977fc1f9f00a3>>
+ * @generated SignedSource<<10fca30bfb462f65321542a3f2a854e0>>
  */
 
 "use strict";
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-native-fb-727b3615-20240906";
+exports.version = "19.0.0-native-fb-e210d081-20240909";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<9807006935b9da557abb42575ba96728>>
+ * @generated SignedSource<<379a1b6951d50e45a36c5de64d4bbc79>>
  */
 
 "use strict";
@@ -584,7 +584,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-native-fb-727b3615-20240906";
+exports.version = "19.0.0-native-fb-e210d081-20240909";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-727b3615287074ddaa28069bfbd2dfee8cf73575
+e210d08180a63f42079b91acaa7f6af15eef6d32
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<3e232841a3dfaeb2b161681a98bd0420>>
+ * @generated SignedSource<<47a16a847b1cb448c953dd32e6ff6ac5>>
  */
 
 "use strict";
@@ -17030,11 +17030,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-native-fb-727b3615-20240906",
+        version: "19.0.0-native-fb-e210d081-20240909",
         rendererPackageName: "react-native-renderer",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+        reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
       };
       null !== extraDevToolsConfig &&
         (internals.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<a9a58c18cb3d73421b3239d633dca1f6>>
+ * @generated SignedSource<<f8a2977a268036ae8166fcdb6e3a75c4>>
  */
 
 "use strict";
@@ -10975,11 +10975,11 @@ batchedUpdatesImpl = function (fn, a) {
 var roots = new Map(),
   internals$jscomp$inline_1162 = {
     bundleType: 0,
-    version: "19.0.0-native-fb-727b3615-20240906",
+    version: "19.0.0-native-fb-e210d081-20240909",
     rendererPackageName: "react-native-renderer",
     currentDispatcherRef: ReactSharedInternals,
     findFiberByHostInstance: getInstanceFromNode,
-    reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+    reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
   };
 null !== extraDevToolsConfig &&
   (internals$jscomp$inline_1162.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<b0a3a5866ba0253ef8b11a4ac30094d7>>
+ * @generated SignedSource<<4c2dcefc5b3c5fbc1d954f5a2293729a>>
  */
 
 "use strict";
@@ -11653,11 +11653,11 @@ batchedUpdatesImpl = function (fn, a) {
 var roots = new Map(),
   internals$jscomp$inline_1247 = {
     bundleType: 0,
-    version: "19.0.0-native-fb-727b3615-20240906",
+    version: "19.0.0-native-fb-e210d081-20240909",
     rendererPackageName: "react-native-renderer",
     currentDispatcherRef: ReactSharedInternals,
     findFiberByHostInstance: getInstanceFromNode,
-    reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+    reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
   };
 null !== extraDevToolsConfig &&
   (internals$jscomp$inline_1247.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<2b41dfef7528eee33a66ab96127796e8>>
+ * @generated SignedSource<<871a422e7ae5be3bf6fc4d377aeeed23>>
  */
 
 "use strict";
@@ -17254,11 +17254,11 @@ __DEV__ &&
       shouldSuspendImpl = newShouldSuspendImpl;
     };
     var isomorphicReactPackageVersion = React.version;
-    if ("19.0.0-native-fb-727b3615-20240906" !== isomorphicReactPackageVersion)
+    if ("19.0.0-native-fb-e210d081-20240909" !== isomorphicReactPackageVersion)
       throw Error(
         'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n  - react:                  ' +
           (isomorphicReactPackageVersion +
-            "\n  - react-native-renderer:  19.0.0-native-fb-727b3615-20240906\nLearn more: https://react.dev/warnings/version-mismatch")
+            "\n  - react-native-renderer:  19.0.0-native-fb-e210d081-20240909\nLearn more: https://react.dev/warnings/version-mismatch")
       );
     if (
       "function" !==
@@ -17284,11 +17284,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-native-fb-727b3615-20240906",
+        version: "19.0.0-native-fb-e210d081-20240909",
         rendererPackageName: "react-native-renderer",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromTag,
-        reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+        reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
       };
       null !== extraDevToolsConfig &&
         (internals.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<0493f336afc7c6b207c6429994ddd093>>
+ * @generated SignedSource<<fef432cce9465ea8ae7524b858a71e58>>
  */
 
 "use strict";
@@ -11104,11 +11104,11 @@ function updateContainer(element, container, parentComponent, callback) {
   return lane;
 }
 var isomorphicReactPackageVersion = React.version;
-if ("19.0.0-native-fb-727b3615-20240906" !== isomorphicReactPackageVersion)
+if ("19.0.0-native-fb-e210d081-20240909" !== isomorphicReactPackageVersion)
   throw Error(
     'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n  - react:                  ' +
       (isomorphicReactPackageVersion +
-        "\n  - react-native-renderer:  19.0.0-native-fb-727b3615-20240906\nLearn more: https://react.dev/warnings/version-mismatch")
+        "\n  - react-native-renderer:  19.0.0-native-fb-e210d081-20240909\nLearn more: https://react.dev/warnings/version-mismatch")
   );
 if (
   "function" !==
@@ -11157,11 +11157,11 @@ batchedUpdatesImpl = function (fn, a) {
 var roots = new Map(),
   internals$jscomp$inline_1228 = {
     bundleType: 0,
-    version: "19.0.0-native-fb-727b3615-20240906",
+    version: "19.0.0-native-fb-e210d081-20240909",
     rendererPackageName: "react-native-renderer",
     currentDispatcherRef: ReactSharedInternals,
     findFiberByHostInstance: getInstanceFromTag,
-    reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+    reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
   };
 null !== extraDevToolsConfig &&
   (internals$jscomp$inline_1228.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<c77cd71e9a1796991db7399343369de7>>
+ * @generated SignedSource<<b4c03a2b09caffbdd3eb389ecca00c0b>>
  */
 
 "use strict";
@@ -11783,11 +11783,11 @@ function updateContainer(element, container, parentComponent, callback) {
   return lane;
 }
 var isomorphicReactPackageVersion = React.version;
-if ("19.0.0-native-fb-727b3615-20240906" !== isomorphicReactPackageVersion)
+if ("19.0.0-native-fb-e210d081-20240909" !== isomorphicReactPackageVersion)
   throw Error(
     'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n  - react:                  ' +
       (isomorphicReactPackageVersion +
-        "\n  - react-native-renderer:  19.0.0-native-fb-727b3615-20240906\nLearn more: https://react.dev/warnings/version-mismatch")
+        "\n  - react-native-renderer:  19.0.0-native-fb-e210d081-20240909\nLearn more: https://react.dev/warnings/version-mismatch")
   );
 if (
   "function" !==
@@ -11836,11 +11836,11 @@ batchedUpdatesImpl = function (fn, a) {
 var roots = new Map(),
   internals$jscomp$inline_1313 = {
     bundleType: 0,
-    version: "19.0.0-native-fb-727b3615-20240906",
+    version: "19.0.0-native-fb-e210d081-20240909",
     rendererPackageName: "react-native-renderer",
     currentDispatcherRef: ReactSharedInternals,
     findFiberByHostInstance: getInstanceFromTag,
-    reconcilerVersion: "19.0.0-native-fb-727b3615-20240906"
+    reconcilerVersion: "19.0.0-native-fb-e210d081-20240909"
   };
 null !== extraDevToolsConfig &&
   (internals$jscomp$inline_1313.rendererConfig = extraDevToolsConfig);
diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/shims/ReactNativeTypes.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/shims/ReactNativeTypes.js
@@ -7,7 +7,7 @@
  * @noformat
  * @nolint
  * @flow strict
- * @generated SignedSource<<89361333bb6b688486e35849a9c669a6>>
+ * @generated SignedSource<<3eb929731c259569c7af3b6479e486fe>>
  */
 
 import type {
@@ -234,8 +234,8 @@ export type ReactNativeType = {
   ): ?ElementRef<ElementType>,
   unmountComponentAtNode(containerTag: number): void,
   unmountComponentAtNodeAndRemoveContainer(containerTag: number): void,
-  unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
-  __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: SecretInternalsType,
+  +unstable_batchedUpdates: <T>(fn: (T) => void, bookkeeping: T) => void,
+  +__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: SecretInternalsType,
   ...
 };
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-19.0.0-native-fb-727b3615-20240906`
	`1`	`+19.0.0-native-fb-e210d081-20240909`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-727b3615287074ddaa28069bfbd2dfee8cf73575`
	`1`	`+e210d08180a63f42079b91acaa7f6af15eef6d32`