Fix for UIExplorer example app after static assets changed #3642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic image references to new folder.
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Author
|
I need to update the tests to remove the use of |
Contributor
|
Interesting, can you tell a little bit more about images no loading? While rolling out the new system, the old one should still work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the static asset requiring changed in PR 3523, the UIExplorer app fails to load due to the change in requiring images. This has been corrected by removing the non app-icon
.xcassetsand adding the images to a./imgfolder.