Skip to content

Conversation

@frantic
Copy link
Contributor

@frantic frantic commented Oct 19, 2015

This integrates React Native into Xcode's build process, which lets us automatically handle bundling and packaging image assets.

Tested the script via https://github.com/frantic/ReactNativeAssetsExample

Loaded from packager:
screen shot 2015-10-19 at 3 11 12 pm

Loaded from offline bundle:
screen shot 2015-10-19 at 3 10 58 pm

Android:
screen shot 2015-10-19 at 3 11 20 pm

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @foghina, @javache and @frantic to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 19, 2015
@brentvatne
Copy link
Collaborator

@frantic - so all we need to do is put images in /assets, no more thinking about Images.xcassets?

@frantic
Copy link
Contributor Author

frantic commented Oct 19, 2015

@brentvatne almost. Documentation coming soon. That's something we've been working on for a while, it just has pretty big surface area. The idea is yes, we provide a cross-platform alternative for Images.xcassets - you put your images next to your JS files and require them as you'd require JS file (see this). And behind the scenes packager will figure out what files are needed and we'll bundle them using Xcode (this PR) and Gradle (#3462) hooks.

@frantic
Copy link
Contributor Author

frantic commented Oct 19, 2015

You will still be able to use Images.xcassets or Android drawables if you want to, but this means you'd have to maintain them yourself. require('image!stuff') will be deprecated in favor of good old {uri: 'stuff'} and if you use it – it's going to be your responsibility to make sure those images exist and packaged properly. The only benefit I see for this system is when RN is inside a hybrid app and shares images with it.

We are trying to make the new system ("packager managed assets") available for the next release cut.

@frantic
Copy link
Contributor Author

frantic commented Oct 19, 2015

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1700194630214195/int_phab to review.

@facebook-github-bot
Copy link
Contributor

@frantic updated the pull request.

frantic added a commit to frantic/react-native that referenced this pull request Oct 21, 2015
Internally we don't mirror `scripts` folder from GitHub, which means
when importing facebook#3523 changes to `scripts/e2e-test.sh` will not make it to
GitHub. This commit contains those changes.
@frantic frantic mentioned this pull request Oct 21, 2015
@frantic frantic closed this in be70e32 Oct 22, 2015
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Internally we don't mirror `scripts` folder from GitHub, which means
when importing facebook#3523 changes to `scripts/e2e-test.sh` will not make it to
GitHub. This commit contains those changes.
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Summary: This integrates React Native into Xcode's build process, which lets us automatically handle bundling and packaging image assets.

Tested the script via https://github.com/frantic/ReactNativeAssetsExample

Loaded from packager:
<img width="432" alt="screen shot 2015-10-19 at 3 11 12 pm" src="https://cloud.githubusercontent.com/assets/192222/10593447/be5bc7e8-7678-11e5-8c70-ecc2a1ee24fc.png">

Loaded from offline bundle:
<img width="432" alt="screen shot 2015-10-19 at 3 10 58 pm" src="https://cloud.githubusercontent.com/assets/192222/10593448/be5d5194-7678-11e5-8b02-d492a26cfb81.png">

Android:
<img width="639" alt="screen shot 2015-10-19 at 3 11 20 pm" src="https://cloud.githubusercontent.com/assets/192222/10593449/be5de2d0-7678-11e5-8d3c-0378fc447f15.png">
Closes facebook#3523

Reviewed By: mkonicek

Differential Revision: D2557923

Pulled By: frantic

fb-gh-sync-id: 19957e255993696e793b0162662772efd89f5c1a
Crash-- pushed a commit to Crash--/react-native that referenced this pull request Dec 24, 2015
Internally we don't mirror `scripts` folder from GitHub, which means
when importing facebook#3523 changes to `scripts/e2e-test.sh` will not make it to
GitHub. This commit contains those changes.
Crash-- pushed a commit to Crash--/react-native that referenced this pull request Dec 24, 2015
Summary: This integrates React Native into Xcode's build process, which lets us automatically handle bundling and packaging image assets.

Tested the script via https://github.com/frantic/ReactNativeAssetsExample

Loaded from packager:
<img width="432" alt="screen shot 2015-10-19 at 3 11 12 pm" src="https://cloud.githubusercontent.com/assets/192222/10593447/be5bc7e8-7678-11e5-8c70-ecc2a1ee24fc.png">

Loaded from offline bundle:
<img width="432" alt="screen shot 2015-10-19 at 3 10 58 pm" src="https://cloud.githubusercontent.com/assets/192222/10593448/be5d5194-7678-11e5-8b02-d492a26cfb81.png">

Android:
<img width="639" alt="screen shot 2015-10-19 at 3 11 20 pm" src="https://cloud.githubusercontent.com/assets/192222/10593449/be5de2d0-7678-11e5-8d3c-0378fc447f15.png">
Closes facebook#3523

Reviewed By: mkonicek

Differential Revision: D2557923

Pulled By: frantic

fb-gh-sync-id: 19957e255993696e793b0162662772efd89f5c1a
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 15, 2016
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 15, 2016
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 20, 2016
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 20, 2016
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 20, 2016
hawkrives added a commit to StoDevX/AAO-React-Native that referenced this pull request Aug 25, 2016
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
Summary: This integrates React Native into Xcode's build process, which lets us automatically handle bundling and packaging image assets.

Tested the script via https://github.com/frantic/ReactNativeAssetsExample

Loaded from packager:
<img width="432" alt="screen shot 2015-10-19 at 3 11 12 pm" src="https://cloud.githubusercontent.com/assets/192222/10593447/be5bc7e8-7678-11e5-8c70-ecc2a1ee24fc.png">

Loaded from offline bundle:
<img width="432" alt="screen shot 2015-10-19 at 3 10 58 pm" src="https://cloud.githubusercontent.com/assets/192222/10593448/be5d5194-7678-11e5-8b02-d492a26cfb81.png">

Android:
<img width="639" alt="screen shot 2015-10-19 at 3 11 20 pm" src="https://cloud.githubusercontent.com/assets/192222/10593449/be5de2d0-7678-11e5-8d3c-0378fc447f15.png">
Closes facebook/react-native#3523

Reviewed By: mkonicek

Differential Revision: D2557923

Pulled By: frantic

fb-gh-sync-id: 19957e255993696e793b0162662772efd89f5c1a
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary: This integrates React Native into Xcode's build process, which lets us automatically handle bundling and packaging image assets.

Tested the script via https://github.com/frantic/ReactNativeAssetsExample

Loaded from packager:
<img width="432" alt="screen shot 2015-10-19 at 3 11 12 pm" src="https://cloud.githubusercontent.com/assets/192222/10593447/be5bc7e8-7678-11e5-8c70-ecc2a1ee24fc.png">

Loaded from offline bundle:
<img width="432" alt="screen shot 2015-10-19 at 3 10 58 pm" src="https://cloud.githubusercontent.com/assets/192222/10593448/be5d5194-7678-11e5-8b02-d492a26cfb81.png">

Android:
<img width="639" alt="screen shot 2015-10-19 at 3 11 20 pm" src="https://cloud.githubusercontent.com/assets/192222/10593449/be5de2d0-7678-11e5-8d3c-0378fc447f15.png">
Closes facebook/react-native#3523

Reviewed By: mkonicek

Differential Revision: D2557923

Pulled By: frantic

fb-gh-sync-id: 19957e255993696e793b0162662772efd89f5c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants