Skip to content

Commit edb7332

Browse files
javachefacebook-github-bot
authored andcommitted
Add BUCK targets for OSS hermes targets (#40933)
Summary: Pull Request resolved: #40933 This enables us to have lint coverage (and others) for these files. Visibility is none, so it won't be pulled in to anything. Also removed no-op JSITracing implementation. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50262377 fbshipit-source-id: 6218c7a79b5c0328bed8472590cff9e92006b86e
1 parent 2d8797a commit edb7332

File tree

5 files changed

+1
-41
lines changed

5 files changed

+1
-41
lines changed

packages/react-native/ReactCommon/hermes/executor/HermesExecutorFactory.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
#include <hermes/inspector-modern/chrome/Registration.h>
1818
#include <hermes/inspector/RuntimeAdapter.h>
1919

20-
#include "JSITracing.h"
21-
2220
using namespace facebook::hermes;
2321
using namespace facebook::jsi;
2422

@@ -243,8 +241,6 @@ HermesExecutor::HermesExecutor(
243241
std::shared_ptr<MessageQueueThread> jsQueue,
244242
const JSIScopedTimeoutInvoker& timeoutInvoker,
245243
RuntimeInstaller runtimeInstaller)
246-
: JSIExecutor(runtime, delegate, timeoutInvoker, runtimeInstaller) {
247-
jsi::addNativeTracingHooks(*runtime);
248-
}
244+
: JSIExecutor(runtime, delegate, timeoutInvoker, runtimeInstaller) {}
249245

250246
} // namespace facebook::react

packages/react-native/ReactCommon/hermes/executor/HermesExecutorFactory.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
#include <hermes/hermes.h>
1111
#include <jsireact/JSIExecutor.h>
12-
#include <functional>
1312
#include <utility>
1413

1514
namespace facebook::react {

packages/react-native/ReactCommon/hermes/executor/JSITracing.cpp

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/react-native/ReactCommon/hermes/executor/JSITracing.h

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/react-native/ReactCommon/react/runtime/hermes/HermesInstance.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "HermesInstance.h"
99

10-
#include <JSITracing.h>
1110
#include <jsi/jsilib.h>
1211

1312
#ifdef HERMES_ENABLE_DEBUGGER
@@ -129,8 +128,6 @@ std::unique_ptr<jsi::Runtime> HermesInstance::createJSRuntime(
129128
std::unique_ptr<HermesRuntime> hermesRuntime =
130129
hermes::makeHermesRuntime(runtimeConfigBuilder.build());
131130

132-
jsi::addNativeTracingHooks(*hermesRuntime);
133-
134131
#ifdef HERMES_ENABLE_DEBUGGER
135132
std::unique_ptr<DecoratedRuntime> decoratedRuntime =
136133
std::make_unique<DecoratedRuntime>(

0 commit comments

Comments
 (0)