Skip to content

Commit c94edb1

Browse files
authored
Merge branch 'master' into ActivityIndicator/add-size-prop
2 parents de373a3 + a527ef2 commit c94edb1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+534
-150
lines changed

.flowconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ suppress_type=$FlowIssue
4747
suppress_type=$FlowFixMe
4848
suppress_type=$FixMe
4949

50-
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-8]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
51-
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-8]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
50+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
51+
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
5252
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
5353

5454
unsafe.enable_getters_and_setters=true

Examples/UIExplorer/UIExplorer.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,7 @@
902902
);
903903
runOnlyForDeploymentPostprocessing = 0;
904904
shellPath = /bin/sh;
905-
shellScript = "export NODE_BINARY=node\n$SRCROOT/../../packager/react-native-xcode.sh Examples/UIExplorer/UIExplorerApp.ios.js";
905+
shellScript = "export NODE_BINARY=node\n$SRCROOT/../../packager/react-native-xcode.sh Examples/UIExplorer/js/UIExplorerApp.ios.js";
906906
};
907907
/* End PBXShellScriptBuildPhase section */
908908

Examples/UIExplorer/UIExplorer/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ - (BOOL)application:(__unused UIApplication *)application didFinishLaunchingWith
5252

5353
- (NSURL *)sourceURLForBridge:(__unused RCTBridge *)bridge
5454
{
55-
NSURL *jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"Examples/UIExplorer/UIExplorerApp.ios" fallbackResource:nil];
55+
NSURL *jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"Examples/UIExplorer/js/UIExplorerApp.ios" fallbackResource:nil];
5656

5757
if (!getenv("CI_USE_PACKAGER")) {
5858
jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];

Examples/UIExplorer/UIExplorerIntegrationTests/RCTLoggingTests.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@ - (void)setUp
3838
if (getenv("CI_USE_PACKAGER")) {
3939
NSString *app = @"IntegrationTests/IntegrationTestsApp";
4040
scriptURL = [NSURL URLWithString:[NSString stringWithFormat:@"http://localhost:8081/%@.bundle?platform=ios&dev=true", app]];
41-
RCTAssert(scriptURL != nil, @"No scriptURL set");
4241
} else {
4342
scriptURL = [[NSBundle bundleForClass:[RCTBridge class]] URLForResource:@"main" withExtension:@"jsbundle"];
44-
RCTAssert(scriptURL != nil, @"Could not locate main.jsBundle");
4543
}
44+
RCTAssert(scriptURL != nil, @"No scriptURL set");
4645

4746
_bridge = [[RCTBridge alloc] initWithBundleURL:scriptURL moduleProvider:NULL launchOptions:nil];
4847
NSDate *date = [NSDate dateWithTimeIntervalSinceNow:60];

Examples/UIExplorer/UIExplorerUnitTests/RCTModuleInitNotificationRaceTests.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#import "RCTUtils.h"
2222
#import "RCTUIManager.h"
2323
#import "RCTViewManager.h"
24+
#import "RCTJavaScriptExecutor.h"
2425

2526
#define RUN_RUNLOOP_WHILE(CONDITION) \
2627
{ \

Examples/UIExplorer/UIExplorerUnitTests/RCTModuleInitTests.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#import "RCTBridge+Private.h"
2020
#import "RCTBridgeModule.h"
2121
#import "RCTUtils.h"
22+
#import "RCTJavaScriptExecutor.h"
2223

2324
#define RUN_RUNLOOP_WHILE(CONDITION) \
2425
{ \

Examples/UIExplorer/js/CameraRollView.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ var CameraRollView = React.createClass({
198198

199199
_renderFooterSpinner: function() {
200200
if (!this.state.noMore) {
201-
return <ActivityIndicator style={styles.spinner} />;
201+
return <ActivityIndicator />;
202202
}
203203
return null;
204204
},

Examples/UIExplorer/js/ImageExample.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ var MultipleSourcesExample = React.createClass({
165165
},
166166
render: function() {
167167
return (
168-
<View style={styles.container}>
168+
<View>
169169
<View style={{flexDirection: 'row', justifyContent: 'space-between'}}>
170170
<Text
171171
style={styles.touchableText}
@@ -180,7 +180,7 @@ var MultipleSourcesExample = React.createClass({
180180
</View>
181181
<Text>Container image size: {this.state.width}x{this.state.height} </Text>
182182
<View
183-
style={[styles.imageContainer, {height: this.state.height, width: this.state.width}]} >
183+
style={{height: this.state.height, width: this.state.width}} >
184184
<Image
185185
style={{flex: 1}}
186186
source={[

Examples/UIExplorer/js/ListViewExample.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ var ListViewSimpleExample = React.createClass({
6565
dataSource={this.state.dataSource}
6666
renderRow={this._renderRow}
6767
renderScrollComponent={props => <RecyclerViewBackedScrollView {...props} />}
68-
renderSeparator={this._renderSeperator}
68+
renderSeparator={this._renderSeparator}
6969
/>
7070
</UIExplorerPage>
7171
);
@@ -107,7 +107,7 @@ var ListViewSimpleExample = React.createClass({
107107
)});
108108
},
109109

110-
_renderSeperator: function(sectionID: number, rowID: number, adjacentRowHighlighted: bool) {
110+
_renderSeparator: function(sectionID: number, rowID: number, adjacentRowHighlighted: bool) {
111111
return (
112112
<View
113113
key={`${sectionID}-${rowID}`}

Examples/UIExplorer/js/NavigatorIOSExample.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ const NavigatorIOSExample = React.createClass({
217217
component: NavigatorIOSExamplePage,
218218
passProps: {onExampleExit},
219219
}}
220-
itemWrapperStyle={styles.itemWrapper}
221220
tintColor="#008888"
222221
/>
223222
);

0 commit comments

Comments
 (0)