Move RCTNativeAnimatedModule onto the main queue

ryangomba · Facebook Github Bot 7 · commit bf82a8d1a87d · 2016-08-07T12:58:20.000-07:00
Summary: We're mutating dictionaries on one thread for bookkeeping (anytime we receive a call over the bridge) and iterating over them on the main thread each frame (in `updateAnimations`). Seems like this can all happen on the main thread without issue. Am I missing something? **Test plan (required)** Run UIExplorer NativeAnimated examples before and after - compare the results. Nothing should have changed. Closes #9049 Differential Revision: D3682871 fbshipit-source-id: c6de62063e724b15b9678a9ef0290284e928b31b
diff --git a/Libraries/NativeAnimation/RCTNativeAnimatedModule.m b/Libraries/NativeAnimation/RCTNativeAnimatedModule.m
@@ -47,6 +47,11 @@ - (void)setBridge:(RCTBridge *)bridge
   _propAnimationNodes = [NSMutableSet new];
 }
 
+- (dispatch_queue_t)methodQueue
+{
+  return dispatch_get_main_queue();
+}
+
 RCT_EXPORT_METHOD(createAnimatedNode:(nonnull NSNumber *)tag
                   config:(NSDictionary<NSString *, id> *)config)
 {

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,11 @@ - (void)setBridge:(RCTBridge *)bridge`
`47`	`47`	`_propAnimationNodes = [NSMutableSet new];`
`48`	`48`	`}`
`49`	`49`
	`50`	`+- (dispatch_queue_t)methodQueue`
	`51`	`+{`
	`52`	`+ return dispatch_get_main_queue();`
	`53`	`+}`
	`54`	`+`
`50`	`55`	`RCT_EXPORT_METHOD(createAnimatedNode:(nonnull NSNumber *)tag`
`51`	`56`	`config:(NSDictionary<NSString , id> )config)`
`52`	`57`	`{`