Fabric: Add Unicode prefix to AttachmentCharacter (#28617)

empyrical · facebook-github-bot · commit b0006648e2f5 · 2020-04-19T13:00:17.000-07:00
Summary: This pull request adds a Unicode `u8` prefix to the string literal returned in `AttributedString.cpp`'s `Fragment::AttachmentCharacter()`. This fixes the following error when building on MSVC: ``` react\attributedstring\AttributedString.cpp(21): error C4566: character represented by universal-character-name '\uFFFC' cannot be represented in the current code page (1252) ``` ## Changelog [Internal] [Fixed] - Fabric: Add Unicode prefix to AttachmentCharacter Pull Request resolved: #28617 Test Plan: The Fabric test suite has been ran on a Clang-based build of Fabric on macOS, and no regressions in it have been noted. Differential Revision: D21118078 Pulled By: shergin fbshipit-source-id: c105de5e4edb67fed97ce44153a75d9d380bf588
diff --git a/ReactCommon/fabric/attributedstring/AttributedString.cpp b/ReactCommon/fabric/attributedstring/AttributedString.cpp
@@ -18,7 +18,7 @@ using Fragments = AttributedString::Fragments;
 #pragma mark - Fragment
 
 std::string Fragment::AttachmentCharacter() {
-  return "\uFFFC"; // Unicode `OBJECT REPLACEMENT CHARACTER`
+  return u8"\uFFFC"; // Unicode `OBJECT REPLACEMENT CHARACTER`
 }
 
 bool Fragment::isAttachment() const {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ using Fragments = AttributedString::Fragments;`
`18`	`18`	`#pragma mark - Fragment`
`19`	`19`
`20`	`20`	`std::string Fragment::AttachmentCharacter() {`
`21`		- return "\uFFFC"; // Unicode `OBJECT REPLACEMENT CHARACTER`
	`21`	+ return u8"\uFFFC"; // Unicode `OBJECT REPLACEMENT CHARACTER`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`bool Fragment::isAttachment() const {`