Skip to content

Commit 875f6a7

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Restore installing DevSupport to all the config
Summary: CircleCI was broken because we changed how the `React-Core/DevSupport` pod is installed. ## Changelog: [Internal] - Restore the installation of React-Core/DevSupport Reviewed By: cortinico Differential Revision: D46734714 fbshipit-source-id: 9b8c28837f0485ed0df2f94e417f89b5f0077c7d
1 parent 202b965 commit 875f6a7

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

packages/react-native/scripts/cocoapods/__tests__/flipper-test.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ def test_installFlipperDependencies_installDependencies
2222

2323
# Assert
2424
assert_equal($podInvocationCount, 1)
25-
assert_equal($podInvocation['React-Core/DevSupport'][:path], "../../" )
26-
assert_equal($podInvocation['React-Core/DevSupport'][:configurations], ["Debug"] )
25+
assert_equal($podInvocation['React-Core/DevSupport'][:path], "../../")
2726
end
2827

2928
# ======================= #

packages/react-native/scripts/cocoapods/flipper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
# when the dependencies are installed for a non production app.
2121
#
2222
# @parameter pathToReactNative: the path to the React Native installation
23-
def install_flipper_dependencies(pathToReactNative, configurations: ["Debug"])
24-
pod 'React-Core/DevSupport', :path => "#{pathToReactNative}/", :configurations => configurations
23+
def install_flipper_dependencies(pathToReactNative)
24+
pod 'React-Core/DevSupport', :path => "#{pathToReactNative}/"
2525
end
2626

2727

packages/react-native/scripts/react_native_pods.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ def use_react_native! (
166166

167167
# Flipper now build in Release mode but it is not linked to the Release binary (as specified by the Configuration option)
168168
if flipper_configuration.flipper_enabled
169-
install_flipper_dependencies(prefix, :configurations => flipper_configuration.configurations)
169+
install_flipper_dependencies(prefix)
170170
use_flipper_pods(flipper_configuration.versions, :configurations => flipper_configuration.configurations)
171171
end
172172

0 commit comments

Comments
 (0)