Skip to content

Commit 454e576

Browse files
jblarrivierecortinico
authored andcommitted
fix: build settings for custom build configuration (#43780)
Summary: This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185 Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185 This now applies the setting to every configuration ending with `Debug` ## Changelog: [IOS] [CHANGED] - fix: build settings for custom build configuration Pull Request resolved: #43780 Reviewed By: dmytrorykun Differential Revision: D55688996 Pulled By: cipolleschi fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
1 parent d0dd48b commit 454e576

File tree

1 file changed

+1
-1
lines changed
  • packages/react-native/scripts/cocoapods

1 file changed

+1
-1
lines changed

packages/react-native/scripts/cocoapods/utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def self.add_build_settings_to_pod(installer, settings_name, settings_value, tar
189189
installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result|
190190
if pod_name.to_s == target_pod_name
191191
target_installation_result.native_target.build_configurations.each do |config|
192-
if configuration == nil || (configuration != nil && configuration == config.name)
192+
if configuration == nil || (configuration != nil && config.name.include?(configuration))
193193
config.build_settings[settings_name] ||= '$(inherited) '
194194
config.build_settings[settings_name] << settings_value
195195
end

0 commit comments

Comments
 (0)