Skip to content

Commit 31eb235

Browse files
lunaleapsfacebook-github-bot
authored andcommitted
Fix set-rn-version (#37854)
Summary: Pull Request resolved: #37854 Changelog: [Internal] - Fix `saveFiles` in set-rn-version, incorrect function invoke Reviewed By: NickGerleman Differential Revision: D46582168 fbshipit-source-id: 944e182a88a1aa79bbf47d36ef8395c21dfefb24
1 parent af99a68 commit 31eb235

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

scripts/__tests__/set-rn-version-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ describe('set-rn-version', () => {
156156
sedMock.mockReturnValueOnce({code: 0});
157157
const filesToValidate = [
158158
'packages/react-native/package.json',
159-
'packages/react-native/ReactAndroid/gradle.properties',
160159
'packages/react-native/template/package.json',
161160
];
162161

scripts/set-rn-version.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,14 +155,19 @@ function setReactNativeVersion(argVersion, dependencyVersions, buildType) {
155155
// Create tmp folder for copies of files to verify files have changed
156156
const filesToValidate = [
157157
'packages/react-native/package.json',
158-
'packages/react-native/ReactAndroid/gradle.properties',
159158
'packages/react-native/template/package.json',
160159
];
161160
const tmpVersioningFolder = fs.mkdtempSync(
162161
path.join(os.tmpdir(), 'rn-set-version'),
163162
);
164163
echo(`The tmp versioning folder is ${tmpVersioningFolder}`);
165-
saveFiles(tmpVersioningFolder);
164+
saveFiles(
165+
[
166+
'packages/react-native/package.json',
167+
'packages/react-native/template/package.json',
168+
],
169+
tmpVersioningFolder,
170+
);
166171

167172
setSource(version);
168173
setPackage(version, dependencyVersions);

0 commit comments

Comments
 (0)