Improve error message format for Node's assert.fail

[wsmd]

Summary

This PR fixes incorrect error message format when using Node's assert.fail.

Currently when using assert.fail in a test, We get a message that includes two parts that should be omitted:

• Expected/Received with undefineds
• An empty "Difference".

This was fixed by updating the node assert message helpers in both of jest-jasmine2 and jest-circus to account for the fail operator.

Before

✕ does not print expected/received message for assert.fail (1ms)

● does not print expected/received message for assert.fail

  assert.fail(received, expected)

  Expected value fail to:
    undefined
  Received:
    undefined
  
  Message:
    nooooooo

  Difference:

  Compared values have no visual difference.

    2 | 
    3 | it('does not print expected/received message for assert.fail', () => {
  > 4 |   assert.fail('nooooooo');
      |          ^
    5 | })

    at Object.fail (test.js:4:10)

After

✕ does not print expected/received message for assert.fail (3ms)

● does not print expected/received message for assert.fail

  assert.fail(received, expected)

  Message:
    nooooooo

    2 | 
    3 | it('does not print expected/received message for assert.fail', () => {
  > 4 |   assert.fail('nooooooo');
      |          ^
    5 | })

    at Object.fail (test.js:4:10)

Test plan

Added two new tests to make sure the error message printed for assert.fail looks as expected.

[wsmd]

This stack.match fallback is only needed for Node versions older than v10.11 because it wan't until v10.11.0 that the AssertionError of assert.fail had an operator value set by default (nodejs/node#22694).

[jeysal]

Maybe mention that in a comment, it's common to grep the codebase for things like node 10 when phasing out support for an EOL version

[SimenB]

Missing changelog entry, but the code looks great. Thanks!

[SimenB]

Thank you!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.