-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
expect, jest-snapshot: Change color from green for some args in matcher hints #8812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SimenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, this is really great! Less noise
f057765 to
de12b77
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |








Summary
For matcher args which do not have a received counterpart in red color:
precisionintoBeCloseTonintoHaveBeenNthCalledWithandtoHaveNthReturnedWithhintintoMatchSnapshotandtoThrowErrorMatchingSnapshotEspecially for matchers whose 2 arguments have different effect on criterion
However, either
pathorvalueintoHavePropertycan have received counterpart:Test plan
Updated 97 snapshots
toBeCloseTonthCalledWithnthReturnedWithtoHaveBeenNthCalledWithtoHaveNthReturnedWithSee also pictures in following comments
Baseline at left and improved at right