expect: Improve report when positive CalledWith assertion fails

[pedrottimark]

Summary

Fixes #7884

For positive toHaveBeen*CalledWith assertions:

• Display matcher name in regular black instead of dim color
• Replace sentences with Expected and Received labels
• Display Number of calls at end of report
• Display received call arguments on one line separated by commas with dim color if value is equal to expected, except for the following special cases:

Display line diff for received call which corresponds to expected call number:

• not indented if only one received call
• indented if multiple received calls

Residue: replace line diff with data-driven diff formatted on one line, when it becomes available

@bandersongit These improvements build on recent pull requests:

• expect: Improve report when negative CalledWith assertion fails #8755 for negative toHaveBeen*CalledWith matchers
• expect: Improve report when mock-spy matcher fails, part 4 #8710 for toHave*ReturnedWith matchers
• expect: Improve report when mock-spy matcher fails, part 2 #8649 for simpler mock-spy matchers

Read the following descriptions with the qualifier if they exist:

matcher	report displays calls
toHaveBeenCalledWith	first 3 calls, including called with 0 arguments
toHaveBeenLastCalledWith	last call and either nearest preceding arguments that are equal to expected; otherwise, next-to-last call
toHaveBeenNthCalledWith	nth call and either nearest preceding/following arguments that are equal to expected; otherwise, adjacent calls

Questions

• What do you think about comma following argument when report contains line diff?
• Is dim color relevant to toHave*Returned matchers when received value is equal to expected?

Faithful reviewers, this is last in series of basic improvements to all matchers! Thank you ❤️

Test plan

Updated 34 snapshots

	long name	short name
6	toHaveBeenCalledWith	toBeCalledWith
6	toHaveBeenLastCalledWith	lastCalledWith
5	toHaveBeenNthCalledWith	nthCalledWith

See also pictures in following comments

Example pictures baseline at left and improved at right

[pedrottimark]

Reports when there are multiple calls, which have primitive arguments:

[pedrottimark]

Reports when the received function was not called:

[pedrottimark]

Reports when there is only one call, which has primitive (or zero) arguments:

[pedrottimark]

Report when there is only one call, which has a line-diffable argument:

[pedrottimark]

Reports when there are multiple calls, and the -> call has a line-diffable argument:

[pedrottimark]

Report for positive toHaveBeenCalledWith assertion is only which can display multiple line diffs:

Here is baseline report (which ignores option) versus improved report with --expand option:

Here is improved report with default --no-expand option:

[pedrottimark]

Here is improved report which fixes a mistake in positive toHaveNthReturnedWith for only one call when n is not 1

[jeysal]

Beautiful <3
Only looked through the snaps since it's quite a lot of code changes, but I think the output is perfect this way, including regarding your questions. Trailing comma FTW :D

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.