feat(jest-core): GitHubActionsReporter goes live
#12658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Very nice (this was failing on purpose, of course):
|
mrazauskas
commented
Apr 9, 2022
mrazauskas
changed the title
GitHubActionsReporter goes live (?)GitHubActionsReporter goes live
mrazauskas
commented
Apr 9, 2022
Comment on lines
+348
to
+351
| if (!reporters) { | ||
| this._setupDefaultReporters(collectCoverage); | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Adding NotifyReporter first, allows to return early. Also later reporters && checks become unnecessary.
Contributor
@mrazauskas Quite the opposite -- Thanks a lot for getting this over the finish line! 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #11320
Summary
Here is an attempt to activate
GitHubActionsReporter. If I get it right, it is better to keep it optional and configurable through:reporters: ['default', 'github-actions']. At least this feels good for now.@ockham thanks for the job done. I really want to see
GitHubActionsReporterin action. Apologies if there is any overlap.Test plan
Green CI.