feat(jest-runner): improve typings by exposing TestRunner abstract classes
#12646
Conversation
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Oh yeah, this is awesome!
(Changelog?)
| const runnerContext = {} as TestRunnerContext; | ||
|
|
||
| class CallbackRunner extends CallbackTestRunner { | ||
| async runTests( |
There was a problem hiding this comment.
I was hoping that override here in a test could catch some drift (hence #12648). Apparently override has no effect in this case, because methods are marked abstract.
In the other hand, abstract requires to implement those methods in a derived class. So to have this test passing is still good.
|
@mrazauskas wanna take a stab at a PR in |
|
Yes, I was looking at it already. Will do it after finishing |
|
Awesome 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Following up #12641
Summary
jest-coresupports two kinds of test runner. What ifjest-runnerwould expose two abstract classes, which would help to implement either kind of the runner?For instance
create-jest-runnercould use these types here. Not to say that I would like to have this for my test runner ;DTodo:
Test plan
Green CI.