fix(expect): move typings of .not, .rejects and .resolves modifiers outside of Matchers interface
#12346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current
expecttypings allow to write expectations like this:expect(1).not.not.resolves.rejects.not.rejects.toBe(2). Looks funny. That’s because .not,.rejectsand.resolveslives insideMatchersinterface.I looked at
@types/jest. Their types work correctly, but it was hard to read them. My version is perhaps less perfect, but I think it is easier to read.Test plan
Type tests which will fail on
mainare added. All should pass in CI.