Skip to content

Commit e876ae0

Browse files
authored
Revert "fix(jest-runner): handle test failures with circular objects (#10981) (#11172)
1 parent ab014c1 commit e876ae0

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
- `[jest-reporter]` Handle empty files when reporting code coverage with V8 ([#10819](https://github.com/facebook/jest/pull/10819))
5151
- `[jest-resolve]` Replace read-pkg-up with escalade package ([#10781](https://github.com/facebook/jest/pull/10781))
5252
- `[jest-resolve]` Disable `jest-pnp-resolver` for Yarn 2 ([#10847](https://github.com/facebook/jest/pull/10847))
53-
- `[jest-runner]` Handle test failures with circular objects ([#10981](https://github.com/facebook/jest/pull/10981))
5453
- `[jest-runtime]` [**BREAKING**] Do not inject `global` variable into module wrapper ([#10644](https://github.com/facebook/jest/pull/10644))
5554
- `[jest-runtime]` [**BREAKING**] remove long-deprecated `jest.addMatchers`, `jest.resetModuleRegistry`, and `jest.runTimersToTime` ([#9853](https://github.com/facebook/jest/pull/9853))
5655
- `[jest-runtime]` Fix stack overflow and promise deadlock when importing mutual dependant ES module ([#10892](https://github.com/facebook/jest/pull/10892))

e2e/__tests__/circularInequality.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ afterEach(() => {
2626
cleanup(tempDir);
2727
});
2828

29-
test('handles circular inequality properly', async () => {
29+
test.skip('handles circular inequality properly', async () => {
3030
const testFileContent = `
3131
it('test', () => {
3232
const foo = {};

packages/jest-runner/src/index.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,7 @@ export default class TestRunner {
166166

167167
const worker = new Worker(TEST_WORKER_PATH, {
168168
exposedMethods: ['worker'],
169-
forkOptions: {
170-
// use advanced serialization in order to transfer objects with circular references
171-
// @ts-expect-error: option does not exist on the node 10 types
172-
serialization: 'advanced',
173-
stdio: 'pipe',
174-
},
169+
forkOptions: {stdio: 'pipe'},
175170
maxRetries: 3,
176171
numWorkers: this._globalConfig.maxWorkers,
177172
setupArgs: [

0 commit comments

Comments
 (0)