Intl.DateTimeFormat throws and RangeError "Invalid timezone name!" when valid IANA timezone is provided

[anton-patrushev]

Bug Description

Intl.DateTimeFormat API for Android is broken. Please see Steps To Reproduce section to understand the problem.

• I have run gradle clean and confirmed this bug does not occur with JSC

Hermes version: 0.8.1
React Native version (if any): 0.65.0-rc.4
OS version (if any): macOS BigSur 11.5.1 (Intel)
Platform (most likely one of arm64-v8a, armeabi-v7a, x86, x86_64): x86

Steps To Reproduce

1. call Intl.DateTimeFormat with valid IANA timeZone

code example:

const date = new Date('2021-08-13T14:00:00Z');

console.log(
  Intl.DateTimeFormat(undefined, {
    timeZone: 'America/New_York',
    month: 'numeric',
    day: 'numeric',
    hour: 'numeric',
    minute: 'numeric',
  }).format(date),
);

Actual Behavior

Throws an RangeError: com.facebook.hermes.intl.JSRangeErrorException: Invalid timezone name!, js engine: hermes

The Expected Behavior

Should not throw any errors and print to console "8/13, 10:00 AM"

[anton-patrushev]

Please, pay attention to this PR. I have investigated the source of the issue and tried to provide fix for this bug.

[anton-patrushev]

Any updates here?

[bviebahn]

Would be great if this could be fixed.

[wojciechkrol]

Any update with this issue?

[chiubaka]

Similarly encountering this. Am also using Luxon like it seems like a few other on this thread may be.

Of note, I can use @formatjs polyfills to get around the error, but for whatever reason the @formatjs polyfills cause intolerably slow performance on Android. The app becomes virtually unusable.

@Huxpro This is, unfortunately, a huge (but I think the last) blocker to my migrating to Hermes, as you had suggested here when you added the "show source" directive: mrousavy/react-native-vision-camera#292.

[andreialecu]

Of note, I can use @formatjs polyfills to get around the error, but for whatever reason the @formatjs polyfills cause intolerably slow performance on Android. The app becomes virtually unusable.

Some information about this here: andreialecu/formatjs-datetimeformat-perf#1

There's a patch at the bottom of the thread which helps quite a lot.

However, now that the linked PR has been merged, I'm hoping to be able to get rid of the formatjs polyfills entirely myself.

[vladyslavNiemtsev]

Hi, guys! Thanks for your updates!

Could you please confirm that this issue is resolved with latest Hermes updates?

[andreialecu]

This is indeed resolved as of Hermes 0.10.0 and later.

[vladyslavNiemtsev]

It's a really great news! Thanks guys!

Could we close the issue?

[anton-patrushev]

It was fixed in scope this PR.
So now Android Hermes starting from the 0.10.0 version should support Intl API correctly.
So I believe as an author of this issue I should close it in that case.

@vladyslavNiemtsev FYI