From 2a54f4c407f5ddfd5250fe57fec2c295620177e7 Mon Sep 17 00:00:00 2001 From: Joshua Robinson Date: Wed, 6 Feb 2019 14:31:35 -0500 Subject: [PATCH 1/4] Add additional information for postcss errors --- packages/react-scripts/scripts/build.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index 8cd1ad77ee..64159feded 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -151,8 +151,22 @@ function build(previousFileSizes) { if (!err.message) { return reject(err); } + + let errMessage = err.message; + + // Add additional information for postcss errors + if (err.hasOwnProperty('postcssNode')) { + const source = err['postcssNode'].source; + errMessage += '\n' + path.basename(source.input.file) + + '\nCompileError: Begins at selector ' + + err['postcssNode'].selector +' (' + + err['postcssNode'].source.start.line + ':' + + source.start.column + + ')'; + } + messages = formatWebpackMessages({ - errors: [err.message], + errors: [errMessage], warnings: [], }); } else { From d772af384cac2d896c6640bc09766069b86a71a3 Mon Sep 17 00:00:00 2001 From: Joshua Robinson Date: Wed, 6 Feb 2019 15:29:54 -0500 Subject: [PATCH 2/4] Add additional information for postcss errors (simplify) --- packages/react-scripts/scripts/build.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index 64159feded..e3f3a35ca1 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -156,12 +156,15 @@ function build(previousFileSizes) { // Add additional information for postcss errors if (err.hasOwnProperty('postcssNode')) { - const source = err['postcssNode'].source; - errMessage += '\n' + path.basename(source.input.file) + + errMessage += + '\n' + + path.basename(err['postcssNode'].source.input.file) + '\nCompileError: Begins at selector ' + - err['postcssNode'].selector +' (' + - err['postcssNode'].source.start.line + ':' + - source.start.column + + err['postcssNode'].selector + + ' (' + + err['postcssNode'].source.start.line + + ':' + + err['postcssNode'].source.start.column + ')'; } From 5d3d24f598a73040a20df7a83e1066237ae4b598 Mon Sep 17 00:00:00 2001 From: Joshua Robinson Date: Tue, 5 Mar 2019 00:49:19 -0500 Subject: [PATCH 3/4] Remove chunkname from postCSS compile error --- packages/react-scripts/scripts/build.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index e3f3a35ca1..24ecd76ef2 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -157,9 +157,7 @@ function build(previousFileSizes) { // Add additional information for postcss errors if (err.hasOwnProperty('postcssNode')) { errMessage += - '\n' + - path.basename(err['postcssNode'].source.input.file) + - '\nCompileError: Begins at selector ' + + '\nCompileError: Begins at CSS selector ' + err['postcssNode'].selector + ' (' + err['postcssNode'].source.start.line + From b181947fc2b59453bdd2336615d1f51657e2c76e Mon Sep 17 00:00:00 2001 From: Joshua Robinson Date: Tue, 5 Mar 2019 00:53:04 -0500 Subject: [PATCH 4/4] Remove line number from postCSS compile error --- packages/react-scripts/scripts/build.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js index 24ecd76ef2..25dd33ebdc 100644 --- a/packages/react-scripts/scripts/build.js +++ b/packages/react-scripts/scripts/build.js @@ -158,12 +158,7 @@ function build(previousFileSizes) { if (err.hasOwnProperty('postcssNode')) { errMessage += '\nCompileError: Begins at CSS selector ' + - err['postcssNode'].selector + - ' (' + - err['postcssNode'].source.start.line + - ':' + - err['postcssNode'].source.start.column + - ')'; + err['postcssNode'].selector; } messages = formatWebpackMessages({