refactor: Change parser function

Author: Aleksandr Startsev

crates/macros/src/impl_.rs

@@ -160,12 +160,6 @@ pub struct Constant<'a> {
     pub docs: Vec<String>,
 }
 
-impl<'a> Constant<'a> {
-    pub fn new(name: String, ident: &'a syn::Ident, docs: Vec<String>) -> Self {
-        Self { name, ident, docs }
-    }
-}
-
 impl<'a> ParsedImpl<'a> {
     /// Create a new, empty parsed impl block.
     ///

crates/macros/src/interface.rs

@@ -1,7 +1,9 @@
 use crate::builders::FunctionBuilder;
-use crate::flags::{ClassFlags, MethodFlags};
-use crate::{builders::ClassBuilder, class::ClassEntryInfo, convert::IntoZvalDyn, describe::DocComments};
 use crate::error::Result;
+use crate::flags::{ClassFlags, MethodFlags};
+use crate::{
+    builders::ClassBuilder, class::ClassEntryInfo, convert::IntoZvalDyn, describe::DocComments,
+};
 
 pub struct InterfaceBuilder {
     class_builder: ClassBuilder,
@@ -42,4 +44,3 @@ impl InterfaceBuilder {
         self.class_builder
     }
 }
-

src/builders/interface.rs

@@ -5,9 +5,9 @@ mod class;
 #[cfg(feature = "enum")]
 mod enum_builder;
 mod function;
-mod interface;
 #[cfg(all(php82, feature = "embed"))]
 mod ini;
+mod interface;
 mod module;
 #[cfg(feature = "embed")]
 mod sapi;

src/builders/mod.rs

@@ -1,6 +1,8 @@
 use std::{convert::TryFrom, ffi::CString, mem, ptr};
 
 use super::{ClassBuilder, FunctionBuilder};
+#[cfg(feature = "enum")]
+use crate::{builders::enum_builder::EnumBuilder, enum_::RegisteredEnum};
 use crate::{
     builders::interface::InterfaceBuilder,
     class::RegisteredClass,
@@ -11,8 +13,6 @@ use crate::{
     zend::{FunctionEntry, ModuleEntry},
     PHP_DEBUG, PHP_ZTS,
 };
-#[cfg(feature = "enum")]
-use crate::{builders::enum_builder::EnumBuilder, enum_::RegisteredEnum};
 
 /// Builds a Zend module extension to be registered with PHP. Must be called
 /// from within an external function called `get_module`, returning a mutable

src/builders/module.rs

@@ -21,7 +21,6 @@ pub mod flags;
 pub mod macros;
 pub mod boxed;
 pub mod class;
-pub mod interface;
 #[cfg(any(docs, feature = "closure"))]
 #[cfg_attr(docs, doc(cfg(feature = "closure")))]
 pub mod closure;
@@ -31,6 +30,7 @@ pub mod describe;
 pub mod embed;
 #[cfg(feature = "enum")]
 pub mod enum_;
+pub mod interface;
 #[doc(hidden)]
 pub mod internal;
 pub mod props;

src/lib.rs

@@ -29,7 +29,4 @@ public function refToLikeThisClass(
 
 assert(is_a($f, Throwable::class));
 assert($f->nonStatic('Rust') === 'Rust - TEST');
-assert(ExtPhpRs\Interface\EmptyObjectInterface::HELLO === "HELLO");
-assert($f::HELLO === "HELLO");
-assert(Test::HELLO === "HELLO");
 assert($f->refToLikeThisClass('TEST', $f) === 'TEST - TEST | TEST - TEST');

tests/src/integration/interface/interface.php

@@ -9,8 +9,6 @@ use ext_php_rs::{php_module, prelude::ModuleBuilder};
 #[php(extends(ce = ce::throwable, stub = "\\Throwable"))]
 #[php(name = "ExtPhpRs\\Interface\\EmptyObjectInterface")]
 pub trait EmptyObjectTrait {
-    const HELLO: &'static str = "HELLO";
-
     fn void();
 
     fn non_static(&self, data: String) -> String;