Issue 404: Non-deterministic validation result when useDefaults are u… #405
Conversation
erosb
left a comment
erosb
left a comment
There was a problem hiding this comment.
Thank you for reporting the issue and raising the PR. It is a bit hacky solution and similar problems can arise later, but if it works for you I'm fine with it. I added a change request.
| .filter(schema -> !(schema instanceof CombinedSchema)) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| combined.addAll(others); |
There was a problem hiding this comment.
As far as I understand here you add the others to a list that was returned by Collectors.toList(). The problem with that is, there is no guarantee for the mutability of this list. As the javadoc says:
There are no guarantees on the type, mutability, serializability, or thread-safety of the List returned;
So please replace this method implementation with any of the followings:
- a plain old
forloop and collecting into two separate ArrayLists Collectors#toCollection(Supplier)so that you can make sure your stream collects into a mutable list- or you can have only one stream and sort it based on a comparator sorting by an
instanceof CombinedSchemaexpression
There was a problem hiding this comment.
Updated the PR with requested changes and added more test coverage. Took the comparator approach.
…sed with combined schema dependencies
|
This looks good now, thank you for addressing my comments. |
Maintain insertion order for subschemas of CombinedSchema. This is an alternative to #519 that maintains the subschemas in insertion order. The subschemas were originally maintained in insertion order, but it was changed due to #405, which ensured that subschemas that were of type CombinedSchema were visited first during validation, and by #498, which tries to maintain a stable order for "equivalent" instances. This PR simply restores the insertion order, but maintains an internally sorted collection for the two purposes listed above, namely visiting subschemas during validation and equivalence checks during equals/hashCode.
3 participants
…sed with combined schema dependencies