Client: Geth genesis parser minor fix #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
added
type: bug
PR state: needs review
package: client
target: master
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Please let Ryan have a look on this as well before merging, I guess he has got some insight here on the original implementation. |
| params.genesis.hash, | ||
| '0x3b8fb240d288781d4aac94d3fd16809ee413bc99294a085798a589dae51ddd4a' | ||
| ) | ||
| t.equals(params.genesis.baseFeePerGas, json.baseFeePerGas) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a logic where if the london block was zero and the
baseFeePerGasundefined, we would set thebaseFeePerGasto1000000000, otherwise, it would be undefined, this would not allow us to set thebaseFeePerGason the genesis initialization when parsing it with geth format. Now this logic has been moved to the block package (It was done by Ryan a few weeks ago)