Clean up unnecessary persistent connection logic for batch:

- Now that we separate send and receive for batching, we no longer have
  to create a workaround for response formatters to contract calls. We
  pass all response formatters together as we do with regular contract
  calls, to be applited to the response as it comes back.

- from comment on PR #3705: move skip marker to decorator

Author: fselmo

tests/integration/go_ethereum/test_goethereum_legacy_ws.py

@@ -55,11 +55,12 @@ def w3(start_geth_process_and_yield_port):
     return _w3
 
 
+@pytest.mark.skip("LegacyWebSocketProvider does not support concurrent requests")
 class TestGoEthereumWeb3ModuleTest(GoEthereumWeb3ModuleTest):
     def test_batch_requests_concurrently_with_regular_requests(
         self, w3: "Web3"
     ) -> None:
-        pytest.skip("LegacyWebSocketProvider does not support concurrent requests")
+        pass
 
 
 class TestGoEthereumAdminModuleTest(GoEthereumAdminModuleTest):

web3/contract/utils.py

@@ -46,9 +46,6 @@
 from web3._utils.batching import (
     BatchRequestInformation,
 )
-from web3._utils.compat import (
-    TypeAlias,
-)
 from web3._utils.contracts import (
     prepare_transaction,
 )
@@ -65,7 +62,6 @@
 from web3.types import (
     ABIElementIdentifier,
     BlockIdentifier,
-    RPCEndpoint,
     StateOverride,
     TContractEvent,
     TContractFn,
@@ -485,8 +481,7 @@ async def async_call_contract_function(
             output_types,
         )
 
-        BatchingReturnData: TypeAlias = Tuple[Tuple[RPCEndpoint, Any], Tuple[Any, ...]]
-        request_information = tuple(cast(BatchingReturnData, return_data))
+        request_information = tuple(cast(BatchRequestInformation, return_data))
         method_and_params = request_information[0]
 
         # append return data formatter to result formatters
@@ -503,8 +498,6 @@ async def async_call_contract_function(
         )
         return (method_and_params, response_formatters)
 
-        return return_data
-
     try:
         output_data = async_w3.codec.decode(output_types, return_data)
     except DecodingError as e:

web3/providers/persistent/request_processor.py

@@ -13,10 +13,6 @@
     Union,
 )
 
-from eth_utils.toolz import (
-    compose,
-)
-
 from web3._utils.batching import (
     BATCH_REQUEST_ID,
 )
@@ -228,34 +224,6 @@ def get_request_information_for_response(
 
         return request_info
 
-    def append_result_formatter_for_request(
-        self, request_id: int, result_formatter: Callable[..., Any]
-    ) -> None:
-        cache_key = generate_cache_key(request_id)
-        cached_request_info_for_id: RequestInformation = (
-            self._request_information_cache.get_cache_entry(cache_key)
-        )
-        if cached_request_info_for_id is not None:
-            (
-                current_result_formatters,
-                error_formatters,
-                null_result_formatters,
-            ) = cached_request_info_for_id.response_formatters
-            cached_request_info_for_id.response_formatters = (
-                compose(
-                    result_formatter,
-                    current_result_formatters,
-                ),
-                error_formatters,
-                null_result_formatters,
-            )
-        else:
-            self._provider.logger.debug(
-                "No cached request info for response id `%s`. Cannot "
-                "append response formatter for response.",
-                request_id,
-            )
-
     def append_middleware_response_processor(
         self,
         response: RPCResponse,