Fix incompatibilities with Golang parser generation #14128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a Golang antlr4 parser from the grammar is currently broken due to some idiosyncratic language incompatibilities:
boolean->boolis not supported (upstreaming a fix here: github.com/Add support to Golang codegen for booleans antlr/antlr4#4231)NewExpressionContextstructandfunctionin the same package, causing a redeclaration errorGetStartandGetEndmethodsThis PR fixes the second two by:
NewExpressiontoNewExprwhich changes theNewExpressionContexttype toNewExprContextstartandendtostartIndexandendIndex