Skip to content

core: prevent integer underflow in ReadAllHashesInRange #33126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: prevent integer underflow in ReadAllHashesInRange #33126

wants to merge 1 commit into from
+13 −1

Conversation

@lucia-w
Copy link
Contributor

@lucia-w lucia-w commented Nov 8, 2025

  • ReadAllHashesInRange pre-allocates the result slice with make([]*NumberHash, 0, 1+last-first) while first/last are uint64. If the caller passes an inverted range, it could cause the node to panic.

@lucia-w lucia-w requested a review from rjl493456442 as a code owner November 8, 2025 01:30
@gballet gballet self-assigned this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@gballet gballet

Labels

status:triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucia-w @gballet @rjl493456442