From 98104b27a45e1392adbd9576a5ce3b221ce16df4 Mon Sep 17 00:00:00 2001 From: Marius van der Wijden Date: Mon, 4 Mar 2024 12:02:29 +0100 Subject: [PATCH 1/2] node: fix test if directory already exists --- node/node_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/node/node_test.go b/node/node_test.go index 04810a815bf6..47bbb09bedae 100644 --- a/node/node_test.go +++ b/node/node_test.go @@ -418,7 +418,9 @@ func TestRegisterHandler_Successful(t *testing.T) { // Tests that the given handler will not be successfully mounted since no HTTP server // is enabled for RPC func TestRegisterHandler_Unsuccessful(t *testing.T) { - node, err := New(&DefaultConfig) + cfg := DefaultConfig + cfg.DataDir = t.TempDir() + node, err := New(&cfg) if err != nil { t.Fatalf("could not create new node: %v", err) } From 880f4566302a22e3843d0d3fb2aa4fafb12ce7a6 Mon Sep 17 00:00:00 2001 From: Marius van der Wijden Date: Tue, 5 Mar 2024 14:51:17 +0100 Subject: [PATCH 2/2] node: remove test --- node/node_test.go | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/node/node_test.go b/node/node_test.go index 47bbb09bedae..d1d1e5dfe8fa 100644 --- a/node/node_test.go +++ b/node/node_test.go @@ -415,23 +415,6 @@ func TestRegisterHandler_Successful(t *testing.T) { assert.Equal(t, "success", string(buf)) } -// Tests that the given handler will not be successfully mounted since no HTTP server -// is enabled for RPC -func TestRegisterHandler_Unsuccessful(t *testing.T) { - cfg := DefaultConfig - cfg.DataDir = t.TempDir() - node, err := New(&cfg) - if err != nil { - t.Fatalf("could not create new node: %v", err) - } - - // create and mount handler - handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - w.Write([]byte("success")) - }) - node.RegisterHandler("test", "/test", handler) -} - // Tests whether websocket requests can be handled on the same port as a regular http server. func TestWebsocketHTTPOnSamePort_WebsocketRequest(t *testing.T) { node := startHTTP(t, 0, 0)