Skip to content

core: refactor code #26852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023
Merged

core: refactor code #26852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04529b3
core: refactor code
s7v7nislands Mar 10, 2023
4333b9e
core: drop it from this anonymous goroutine func
s7v7nislands Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,7 +1741,7 @@ func (bc *BlockChain) insertChain(chain types.Blocks, verifySeals, setHead bool)
throwaway, _ := state.New(parent.Root, bc.stateCache, bc.snaps)

go func(start time.Time, followup *types.Block, throwaway *state.StateDB, interrupt *uint32) {
bc.prefetcher.Prefetch(followup, throwaway, bc.vmConfig, &followupInterrupt)
bc.prefetcher.Prefetch(followup, throwaway, bc.vmConfig, interrupt)
Copy link
Member

@karalabe karalabe Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, but I think this was probably some leftover from a previous code or refactor. There's no need really for this to be passed as a parameter to the function. Instead of your change, we should IMO just drop the interrupt *uint32 param.

Copy link
Member

@karalabe karalabe Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean drop if from this anonymous goroutine func.

Copy link
Contributor Author

@s7v7nislands s7v7nislands Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


blockPrefetchExecuteTimer.Update(time.Since(start))
if atomic.LoadUint32(interrupt) == 1 {
Expand Down