Skip to content

Conversation

@qhenkart
Copy link
Contributor

Currently the DNS propagation request has a heavy and unnecessary bottleneck. Under the hood the route53 waiter stays in a thread blocking loop checking a single entry every 30 seconds over 60 attempts. Check out the source code here. The current implementation makes a single change, then waits for the propagation to finish before making the second change. AWS averages around 60 seconds for propagation, which means the current implementation takes about (60s)n, increasing by 60-90 seconds for each entry that needs to be changed, potentially creating very long wait times

This is a simple optimization extracted from a previous PR #22360 and discussed with @fjl to make all of the DNS changes first, and only after, wait for the response for each one. This improves the time complexity to roughly (60s)1. If I had 3 changes to make, the original implementation would take around 3-4 minutes. The new implementation bundles the changes together so the operation should now take ~60-90 seconds total, and would not increase dramatically with more changes

@fjl fjl closed this Mar 19, 2021
@fjl
Copy link
Contributor

fjl commented Mar 19, 2021

Closed because I merged #22360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants