core/vm, params: implement EIP2200, SSTORE optimizations #19964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Aug 15, 2019
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
This PR looks good to me, and primarily I'm certain it will not screw with anything. Whether it is correct or not is better left for testing, which this PR enables us to do. So I approve
rjl493456442
approved these changes
Aug 18, 2019
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
LGTM, at least it's consistent with EIP
This was referenced Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.