[WIP] console, jsre: replace otto with goja #19761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
changed the title
gballet
force-pushed
the
replace-otto-with-goja
branch
from
f33a57f to
f857b80
Compare
gballet
force-pushed
the
replace-otto-with-goja
branch
from
0adb7ae to
fb7aad4
Compare
gballet
added a commit
to gballet/go-ethereum
that referenced
this pull request
Dec 18, 2019
Completion tests still seem to fail
Member
Author
|
Not going to rebase this, work reported to #20470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #14649 by replacing otto with goja. It's still work in progress because loading web3.js causes some issues and it could be that goja doesn't handle exports properly. I'm putting this up for discussion in the meantime.