core, light: get rid of the dual mutexes, hard to reason with #18436
+44
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2019
Contributor
|
Haven't reviewed the code yet, but a fast-sync was completed with this PR without problems on |
Contributor
|
Full sync at |
Contributor
|
Full sync at |
Contributor
|
Full sync at |
|
How can I repair it? |
|
Even with the update, I get the same error. |
ninjaahhh
reviewed
Apr 19, 2019
ninjaahhh
left a comment
ninjaahhh
left a comment
There was a problem hiding this comment.
just curious, will the following scenario cause a dead lock? though as the comment says, it only happens if the database is corrupted or empty
bc.SetHead -> bc.loadLastState -> bc.Reset -> bc.ResetWithGenesisBlock -> bc.SetHead
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 28, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #18421 and #18388.
The block chain and light chain currently have two mutexes that protect its internal state:
muandchainmu. Themusupposed to protect internal state from getting corrupted whilstchaimufrom multiple modifications to the chain. However, modifying the internal state is equivalent to modifying the chain.Most of our code ended up only locking
mu(e.g. Rollback, SetHead), which although weren't chain insertions, they could really screw up the inserter. The reason this didn't blow up earlier is because most of these method calls are serialized by the downloader, hiding the ticking time bomb. Apparently a side chain import PR managed to destabilize the event orders and somehow triggered a chain modification without lockingmu.