internal/cmdtest: Expose process exit status and errors #18046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
approved these changes
Nov 10, 2018
acud
approved these changes
Nov 10, 2018
Contributor
jpeletier
force-pushed
the
expose-testcmd-exitstatus
branch
from
b8fd32f to
52fdb01
Compare
zsfelfoldi
pushed a commit
to zsfelfoldi/go-ethereum
that referenced
this pull request
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the Test Command's OS exit code. This is useful for tests that expect the command to fail or fail with a specific error code. I plan to refactor some Swarm Feed's CLI tests to use this.