common: remove Clone

Author: fjl

common/types.go

@@ -339,15 +339,6 @@ func (a Address) Value() (driver.Value, error) {
 	return a[:], nil
 }
 
-// Clone returns a pointer to a copy of [a] (or nil if [a] is nil)
-func (a *Address) Clone() *Address {
-	if a == nil {
-		return nil
-	}
-	cpy := *a
-	return &cpy
-}
-
 // ImplementsGraphQLType returns true if Hash implements the specified GraphQL type.
 func (a Address) ImplementsGraphQLType(name string) bool { return name == "Address" }
 

common/types_test.go

@@ -453,29 +453,6 @@ func TestAddress_Format(t *testing.T) {
 	}
 }
 
-func TestCopyAddress(t *testing.T) {
-	addrBytes := make([]byte, 20)
-	addr := BytesToAddress(addrBytes)
-	if !bytes.Equal(addr.Bytes(), addrBytes) {
-		t.Fatalf("Expected original address bytes to be unmodified")
-	}
-	addrPtr := &addr
-	cpy := addrPtr.Clone()
-	cpy.SetBytes([]byte("deadbeef"))
-	if !bytes.Equal(addr.Bytes(), addrBytes) {
-		t.Fatal("Expected original address bytes to be unmodified")
-	}
-	if bytes.Equal(cpy.Bytes(), addrBytes) {
-		t.Fatal("Expected modified address to no longer match original byte slice")
-	}
-
-	var nilAddr *Address
-	copiedNilAddr := nilAddr.Clone()
-	if copiedNilAddr != nil {
-		t.Fatalf("Expected copied nil address to be nil, but got %s", copiedNilAddr)
-	}
-}
-
 func TestHash_Format(t *testing.T) {
 	var hash Hash
 	hash.SetBytes([]byte{