core/vm: remove unnecessary memset for Memory.Set32

qianbin · qianbin · commit 05a2af40ec42 · 2022-05-10T22:53:55.000+08:00
diff --git a/core/vm/memory.go b/core/vm/memory.go
@@ -55,8 +55,6 @@ func (m *Memory) Set32(offset uint64, val *uint256.Int) {
 	if offset+32 > uint64(len(m.store)) {
 		panic("invalid memory: store empty")
 	}
-	// Zero the memory area
-	copy(m.store[offset:offset+32], []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0})
 	// Fill in relevant bits
 	val.WriteToSlice(m.store[offset:])
 }

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,6 @@ func (m Memory) Set32(offset uint64, val uint256.Int) {`
`55`	`55`	`if offset+32 > uint64(len(m.store)) {`
`56`	`56`	`panic("invalid memory: store empty")`
`57`	`57`	`}`
`58`		`- // Zero the memory area`
`59`		`- copy(m.store[offset:offset+32], []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0})`
`60`	`58`	`// Fill in relevant bits`
`61`	`59`	`val.WriteToSlice(m.store[offset:])`
`62`	`60`	`}`