fix: correct parent typing for rule visitors #172
+49
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
reviewed
Oct 27, 2025
1 task
jaymarvelz
changed the title
JSONRuleVisitor
DMartens
reviewed
Oct 29, 2025
DMartens
reviewed
Oct 29, 2025
| //------------------------------------------------------------------------------ | ||
|
|
||
| /** Adds matching `:exit` selectors for all properties of a `RuleVisitor`. */ | ||
| type WithExit<RuleVisitorType extends RuleVisitor> = { |
There was a problem hiding this comment.
I think this should be a shared helper from @eslint/core as all ESLint languages require it.
Contributor
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
Member
|
@jaymarvelz are you still working on this? There are some outstanding comments to respond to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
To correct the
JSONRuleVisitortype definitions and improve maintainability by introducing aWithExithelper (copied from eslint/markdown). This ensures:exitselectors are automatically generated for all node types and simplifies visitor type definitions.What changes did you make? (Give an overview)
WithExit<RuleVisitorType>helper type to automatically add:exitvariants.JSONRuleVisitorinterface with a version usingWithExit.Related Issues
Is there anything you'd like reviewers to focus on?