Skip to content

Small performance optimization (hash already calculated) #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2022
Merged

Small performance optimization (hash already calculated) #4053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd5c30
Small performance optimization (hash already calculated)
yperbasis May 3, 2022
456b8c2
Merge branch 'devel' into merge_stuff_1
yperbasis May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions turbo/stages/headerdownload/header_algos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,13 +912,14 @@ func (hd *HeaderDownload) ProcessSegmentPOS(segment ChainSegment, tx kv.Getter,
log.Trace("Collecting...", "from", segment[0].Number, "to", segment[len(segment)-1].Number, "len", len(segment))
for _, segmentFragment := range segment {
header := segmentFragment.Header
if header.Hash() != hd.posAnchor.parentHash {
log.Warn("Unexpected header", "hash", header.Hash(), "expected", hd.posAnchor.parentHash)
headerHash := segmentFragment.Hash
if headerHash != hd.posAnchor.parentHash {
log.Warn("Unexpected header", "hash", headerHash, "expected", hd.posAnchor.parentHash)
return []PenaltyItem{{PeerID: peerId, Penalty: BadBlockPenalty}}, nil
}

headerNumber := header.Number.Uint64()
if err := hd.headersCollector.Collect(dbutils.HeaderKey(headerNumber, header.Hash()), segmentFragment.HeaderRaw); err != nil {
if err := hd.headersCollector.Collect(dbutils.HeaderKey(headerNumber, headerHash), segmentFragment.HeaderRaw); err != nil {
return nil, err
}

Expand Down