Skip to content

Conversation

@tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Jun 20, 2020

Release version 0.11.6.

I added notes in the changelog for the recent PRs after version 0.11.6: #660

All the changes are docs or bugfixes, so I just bumped the patch version.


Note: After/if merging, this would require adding a manual release in GitHub, including the new changelog items.

@tiangolo
Copy link
Contributor Author

I'm not sure if there is a convention for the format of the messages in the changelog, I based it on the previous ones.

The current order in this PR is latest/newest PRs merged on top. The same way that latest version numbers are on top.

I'm not including PR numbers nor contributors, and not including small changes like typos.

@tomchristie let me know if I should adjust that or if you would prefer to change the info in the changelog somehow.

@tiangolo tiangolo requested a review from a team July 16, 2020 15:28
@lovelydinosaur
Copy link
Contributor

The current order in this PR is

Don't really mind about ordering here.

I'm [...] not including small changes like typos.

Indeed. We should only include behavioural changes in the release notes. Docs changes shouldn't really be in the release notes (since they're not actually part of the package release) nor should refactorings (since they ought to be transparent to the end user).

@lovelydinosaur
Copy link
Contributor

And thanks so much for cracking on with this! 😃

@tiangolo
Copy link
Contributor Author

Perfect! Done ✔️

...I wish I could do more, I keep promising myself I'll do more here and on Starlette and then the other issues/PRs in FastAPI hold me there 🤦 😅

@lovelydinosaur
Copy link
Contributor

Don't sweat it, we're all doing what we can, where we can. 😃

@lovelydinosaur lovelydinosaur merged commit f623916 into Kludex:master Jul 17, 2020
@lovelydinosaur
Copy link
Contributor

@tiangolo Ya fancy issuing the release? Otherwise I'm happy to sort that.

tag: 0.11.6
title: Version 0.11.6
description: * Fix overriding the root logger.

@tiangolo tiangolo deleted the version-0.11.6 branch July 17, 2020 14:33
@tiangolo
Copy link
Contributor Author

Awesome, thanks! 🎉

Ya fancy issuing the release?

Sure thing! 🤩 🚀 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants