Skip to content

Commit 90f0321

Browse files
authored
Merge pull request #1336 from bertdeblock/importing-inject-from-ember-service
Add guide for `importing-inject-from-ember-service` deprecation
2 parents 75af194 + ecd5e5e commit 90f0321

File tree

5 files changed

+35
-0
lines changed

5 files changed

+35
-0
lines changed

app/templates/index.hbs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@
5252
<li class='list-unstyled' data-test-ember-5-link>
5353
<LinkTo @route='ember' @model='v5.x'>v5.x</LinkTo>
5454
</li>
55+
<li class='list-unstyled' data-test-ember-6-link>
56+
<LinkTo @route='ember' @model='v6.x'>v6.x</LinkTo>
57+
</li>
5558
</ul>
5659
</li>
5760
<li class='item list-unstyled'>
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
---
2+
title: Importing `inject` from `@ember/service`
3+
until: 7.0.0
4+
since: 6.3.0
5+
---
6+
7+
Importing `inject` from `@ember/service` is deprecated. Please import `service` instead.
8+
9+
Example:
10+
11+
```js {data-filename="my-route.js" data-diff="-2,+3"}
12+
import { Route } from '@ember/routing/route';
13+
import { inject as service } from '@ember/service';
14+
import { service } from '@ember/service';
15+
16+
export default class MyRoute extends Route {
17+
@service store;
18+
}
19+
```

ember-cli-build.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@ module.exports = function (defaults) {
2020
prember: {
2121
urls: [
2222
'/',
23+
'/v6.x',
2324
'/v5.x',
2425
'/v4.x',
2526
'/v3.x',
2627
'/v2.x',
2728
'/v1.x',
29+
'/ember/v6.x',
2830
'/ember/v5.x',
2931
'/ember/v4.x',
3032
'/ember/v3.x',

lib/content-docs-generator/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const contentFolders = [
1111
'ember/v3',
1212
'ember/v4',
1313
'ember/v5',
14+
'ember/v6',
1415
'ember-data/v2',
1516
'ember-data/v3',
1617
'ember-data/v4',

tests/acceptance/visual-regression-test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,16 @@ module('Acceptance | visual regression', function (hooks) {
110110

111111
await percySnapshot('ember-5.x');
112112

113+
// v6.x Ember
114+
await click('[data-test-main-deprecations-link]');
115+
await click('[data-test-ember-6-link] > a');
116+
117+
assert
118+
.dom('[data-test-deprecations-added-in]')
119+
.hasText('Deprecations Added in Ember 6.x');
120+
121+
await percySnapshot('ember-6.x');
122+
113123
// Individual page
114124
await visit('/id/ember-polyfills-deprecate-assign');
115125
assert.dom('h1').hasText('Deprecation Guide for Ember.assign');

0 commit comments

Comments
 (0)