-
Notifications
You must be signed in to change notification settings - Fork 159
Changes required for Embroider build to support Fastboot apps #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you @SparshithNR for working on updating code based on new review comments. The change looks good to me. |
kratiahuja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, except the concern on wanting to understand the data-fastboot-ignore usecase more.
Updating README so it is for user.
kratiahuja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once CI is completed.
|
This is still an important issue, but after much more end-to-end testing of full apps with fastboot & embroider I don't actually think this is the right solution. Instead of mangling the build output in Also, the earlier reverted version of this feature is still present in the latest release because no release has been cut since it was reverted. |
|
@dnalagatla @ef4 and @rwjblue what needs to happen to this PR before we can cut an embroider version of |
|
This PR is superseded, the equivalent changes were already made in fastboot itself. We probably do need a release of ember-cli-fastboot that upgrades to that newer fastboot. There is also work to do here to make ember-cli-fastboot natively emit the new format accepted by fastboot, although that is not a blocker because fastboot accepts all older formats too. |
This PR address the review comments from #729