This repository was archived by the owner on Oct 8, 2025. It is now read-only.
fix: run compiler in task #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This lets the compiler stdout messgaes to be logged to the client while the RPC is still happening. Previously, the port would message back to the process that was synchronously waiting on the RPC to finish, so it didn't send any log messages to the LSP process until the compiler was done. This made it look like the initial compiler was hanging. Fixes #60
mhanberg
force-pushed
the
2023-07-05-run-compiler-in-task
branch
from
f165b67 to
af50c84
Compare
This was referenced Sep 30, 2023
This was referenced Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the compiler stdout messgaes to be logged to the client while
the RPC is still happening.
Previously, the port would message back to the process that was
synchronously waiting on the RPC to finish, so it didn't send any log
messages to the LSP process until the compiler was done.
This made it look like the initial compiler was hanging.
Fixes #60