Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

lucacervello
Copy link
Contributor

No description provided.

@lucacervello
Copy link
Contributor Author

@mhanberg it was pretty easy but I don't know if storing the parameters as text is the way to go.

Right now my implementation is very naive, it works for basic function like

def foo(bar,baz) do
  :ok
end 

bar, baz is stored in the table

when dealing this function like this

def foo({1, _} = bar, baz) do
  :ok
end 

I don't know how we should store it

Maybe text is not the best way to represent params?

@mhanberg
Copy link
Collaborator

You can store them as a blob using termtobinary and then after querying them do binary to term

@lucacervello lucacervello force-pushed the update-symbols-db-with-params branch from e45d034 to 56ee882 Compare March 13, 2024 17:02
@lucacervello lucacervello marked this pull request as ready for review March 13, 2024 17:02
@mhanberg
Copy link
Collaborator

Fix the tests and then I'll review

@lucacervello lucacervello force-pushed the update-symbols-db-with-params branch from 56ee882 to 7499c57 Compare March 14, 2024 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants