Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

lucacervello
Copy link
Contributor

Closes #59

@lucacervello lucacervello force-pushed the add-snippets branch 2 times, most recently from 8d4449f to 8fbe1c2 Compare March 5, 2024 12:53
@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

Another thing is you need to preserve the documentation in the completion item in the snippet

@lucacervello
Copy link
Contributor Author

lucacervello commented Mar 5, 2024

Should I add a new parameter to the Snippet.get/2 function or use the second one as docs?
Or we don't want Snippet.get/2 to change?

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

Doing a Map.merge(original,snippet) might do the trick, no need to change the snippet function

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 5, 2024

I'll try and play with this soon, currently wrapping up some work on the editor extensions.

@mhanberg
Copy link
Collaborator

mhanberg commented Mar 8, 2024

made a couple changes, otherwise great!

@mhanberg mhanberg enabled auto-merge (squash) March 8, 2024 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snippets

2 participants