Some tests e.g. `WorkerSchemaTests` don't seem to work standalone due to lack of database preparation

[matrixbot]

This issue has been migrated from #15671.

---

 python -m twisted.trial -j 24 tests.storage.test_rollback_worker.WorkerSchemaTests
Running 3 tests.
tests.storage.test_rollback_worker
  WorkerSchemaTests
    test_not_upgraded_current_schema_version_with_outstanding_deltas ... [ERROR]
    test_rolling_back ...                                               [ERROR]
    test_not_upgraded_old_schema_version ...                            [ERROR]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/home/rei/work/synapse/tests/unittest.py", line 121, in new
    return code(orig, *args, **kwargs)
  File "/home/rei/work/synapse/tests/unittest.py", line 225, in setUp
    return orig()
  File "/home/rei/work/synapse/tests/unittest.py", line 340, in setUp
    self.hs = self.make_homeserver(self.reactor, self.clock)
  File "/home/rei/work/synapse/tests/storage/test_rollback_worker.py", line 48, in make_homeserver
    hs = self.setup_test_homeserver(
  File "/home/rei/work/synapse/tests/unittest.py", line 608, in setup_test_homeserver
    hs = setup_test_homeserver(self.addCleanup, **kwargs)
  File "/home/rei/work/synapse/tests/server.py", line 921, in setup_test_homeserver
    prepare_database(
  File "/home/rei/work/synapse/synapse/storage/prepare_database.py", line 155, in prepare_database
    raise UpgradeDatabaseException(EMPTY_DATABASE_ON_WORKER_ERROR)
synapse.storage.prepare_database.UpgradeDatabaseException: Uninitialised database: run the main synapse process to prepare the database schema before starting worker processes.

tests.storage.test_rollback_worker.WorkerSchemaTests.test_not_upgraded_current_schema_version_with_outstanding_deltas
tests.storage.test_rollback_worker.WorkerSchemaTests.test_rolling_back
tests.storage.test_rollback_worker.WorkerSchemaTests.test_not_upgraded_old_schema_version
-------------------------------------------------------------------------------

but the tests work when run as a bigger batch.

It seems like there is interaction between the tests, which doesn't seem ideal...

[MadLittleMods]

synapse.storage.prepare_database.UpgradeDatabaseException: Uninitialised database: run the main synapse process to prepare the database schema before starting worker processes.

I think this applies to anything that overrides the homeserver_to_use in setup_test_homeserver(...). For example, all of the tests that use homeserver_to_use=GenericWorkerServer

It works for the homeserver_to_use=SynapseHomeServer cases as SynapseHomeServer is the class for main Synapse instance and prepares the database as expected.

But for the cases with homeserver_to_use=GenericWorkerServer, we never setup a main homeserver instance to prepare the database.

---

I don't know how/why the tests work when ran together with other tests.