Skip to content

Commit d0e19d3

Browse files
authored
Fix TAC should mark all threads as read e2e test (element-hq#28625)
1 parent b016cf5 commit d0e19d3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

playwright/e2e/spaces/threads-activity-centre/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ export class Helpers {
276276
* Assert that the threads activity centre button has no indicator
277277
*/
278278
async assertNoTacIndicator() {
279-
// Assert by checkng neither of the known indicators are visible first. This will wait
279+
// Assert by checking neither of the known indicators are visible first. This will wait
280280
// if it takes a little time to disappear, but the screenshot comparison won't.
281281
await expect(this.getTacButton().locator("[data-indicator='success']")).not.toBeVisible();
282282
await expect(this.getTacButton().locator("[data-indicator='critical']")).not.toBeVisible();
@@ -376,7 +376,7 @@ export class Helpers {
376376
* Clicks the button to mark all threads as read in the current room
377377
*/
378378
clickMarkAllThreadsRead() {
379-
return this.page.getByLabel("Mark all as read").click();
379+
return this.page.locator("#thread-panel").getByRole("button", { name: "Mark all as read" }).click();
380380
}
381381
}
382382

playwright/e2e/spaces/threads-activity-centre/threadsActivityCentre.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ test.describe("Threads Activity Centre", () => {
146146
await util.openTac();
147147
await util.clickRoomInTac(room1.name);
148148

149-
util.clickMarkAllThreadsRead();
149+
await util.clickMarkAllThreadsRead();
150150

151151
await util.assertNoTacIndicator();
152152
});

0 commit comments

Comments
 (0)