Beats/config view #22177
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| // @ts-ignore | ||
| import { EuiBasicTable, EuiLink } from '@elastic/eui'; | ||
| import React from 'react'; | ||
| import { supportedConfigs } from '../config_schemas'; | ||
| import { ClientSideConfigurationBlock } from '../lib/lib'; | ||
|
|
||
| interface ComponentProps { | ||
| configs: ClientSideConfigurationBlock[]; | ||
| onConfigClick: (action: 'edit' | 'delete', config: ClientSideConfigurationBlock) => any; | ||
| } | ||
|
|
||
| export const ConfigList: React.SFC<ComponentProps> = props => ( | ||
| <EuiBasicTable | ||
| items={props.configs} | ||
| columns={[ | ||
| { | ||
| field: 'type', | ||
| name: 'Type', | ||
| truncateText: false, | ||
| render: (value: string, config: ClientSideConfigurationBlock) => { | ||
| const type = supportedConfigs.find((sc: any) => sc.value === config.type); | ||
|
|
||
| return ( | ||
| <EuiLink onClick={() => props.onConfigClick('edit', config)}> | ||
| {type ? type.text : config.type} | ||
| </EuiLink> | ||
| ); | ||
| }, | ||
| }, | ||
| { | ||
| field: 'block_obj.module', | ||
| name: 'Module', | ||
| truncateText: false, | ||
| render: (item: ClientSideConfigurationBlock) => | ||
| (item && (item.block_obj as any).module) || 'N/A', | ||
| }, | ||
| { | ||
| field: 'description', | ||
| name: 'Description', | ||
| }, | ||
| { | ||
| name: 'Actions', | ||
| actions: [ | ||
| { | ||
| name: 'Remove', | ||
| description: 'Remove this config from tag', | ||
| type: 'icon', | ||
| icon: 'trash', | ||
| onClick: (item: ClientSideConfigurationBlock) => props.onConfigClick('delete', item), | ||
| }, | ||
| ], | ||
| }, | ||
| ]} | ||
| /> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| // @ts-ignore | ||
| import { CommonProps, EuiCodeEditor, EuiCodeEditorProps, EuiFormRow } from '@elastic/eui'; | ||
| // @ts-ignore | ||
| import { FormsyInputProps, withFormsy } from 'formsy-react'; | ||
| import React, { Component, InputHTMLAttributes } from 'react'; | ||
|
|
||
| interface ComponentProps extends FormsyInputProps, CommonProps, EuiCodeEditorProps { | ||
| instantValidation: boolean; | ||
| label: string; | ||
| isReadOnly: boolean; | ||
| mode: 'javascript' | 'yaml'; | ||
| errorText: string; | ||
| fullWidth: boolean; | ||
| helpText: React.ReactElement<any>; | ||
| compressed: boolean; | ||
| onChange(value: string): void; | ||
| onBlur(): void; | ||
| } | ||
|
|
||
| interface ComponentState { | ||
| allowError: boolean; | ||
| } | ||
|
|
||
| class CodeEditor extends Component< | ||
| InputHTMLAttributes<HTMLTextAreaElement> & ComponentProps, | ||
| ComponentState | ||
| > { | ||
| public static defaultProps = { | ||
| passRequiredToField: true, | ||
| }; | ||
|
|
||
| public state = { allowError: false }; | ||
|
|
||
| public componentDidMount() { | ||
| const { defaultValue, setValue } = this.props; | ||
| if (defaultValue) { | ||
| setValue(defaultValue); | ||
| } | ||
| } | ||
|
|
||
| public componentWillReceiveProps(nextProps: ComponentProps) { | ||
| if (nextProps.isFormSubmitted()) { | ||
| this.showError(); | ||
| } | ||
| } | ||
|
|
||
| public handleChange = (value: string) => { | ||
| this.props.setValue(value); | ||
| if (this.props.onChange) { | ||
| this.props.onChange(value); | ||
| } | ||
| if (this.props.instantValidation) { | ||
| this.showError(); | ||
| } | ||
| }; | ||
|
|
||
| public handleBlur = () => { | ||
| this.showError(); | ||
| if (this.props.onBlur) { | ||
| this.props.onBlur(); | ||
| } | ||
| }; | ||
|
|
||
| public showError = () => this.setState({ allowError: true }); | ||
|
|
||
| public render() { | ||
| const { | ||
| id, | ||
| label, | ||
| isReadOnly, | ||
| isValid, | ||
| getValue, | ||
| isPristine, | ||
| getErrorMessage, | ||
| mode, | ||
| fullWidth, | ||
| className, | ||
| helpText, | ||
| } = this.props; | ||
|
|
||
| const { allowError } = this.state; | ||
| const error = !isPristine() && !isValid() && allowError; | ||
|
|
||
| return ( | ||
| <EuiFormRow | ||
| id={id} | ||
| label={label} | ||
| helpText={helpText} | ||
| isInvalid={error} | ||
| error={error ? getErrorMessage() : []} | ||
| > | ||
| <EuiCodeEditor | ||
| id={id} | ||
| name={name} | ||
| mode={mode} | ||
| theme="github" | ||
| value={getValue()} | ||
| isReadOnly={isReadOnly || false} | ||
| isInvalid={error} | ||
| onChange={this.handleChange} | ||
| onBlur={this.handleBlur} | ||
| width={fullWidth ? '100%' : undefined} | ||
| className={className} | ||
| /> | ||
| </EuiFormRow> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export const FormsyEuiCodeEditor = withFormsy(CodeEditor); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| import { CommonProps, EuiFieldText, EuiFieldTextProps, EuiFormRow } from '@elastic/eui'; | ||
| import { FormsyInputProps, withFormsy } from 'formsy-react'; | ||
| import React, { Component, InputHTMLAttributes } from 'react'; | ||
|
|
||
| interface ComponentProps extends FormsyInputProps, CommonProps, EuiFieldTextProps { | ||
| instantValidation?: boolean; | ||
| label: string; | ||
| errorText: string; | ||
| fullWidth: boolean; | ||
| helpText: React.ReactElement<any>; | ||
| compressed: boolean; | ||
| onChange?(e: React.ChangeEvent<HTMLInputElement>, value: any): void; | ||
| onBlur?(e: React.ChangeEvent<HTMLInputElement>, value: any): void; | ||
| } | ||
|
|
||
| interface ComponentState { | ||
| allowError: boolean; | ||
| } | ||
|
|
||
| class FieldText extends Component< | ||
| InputHTMLAttributes<HTMLInputElement> & ComponentProps, | ||
| ComponentState | ||
| > { | ||
| public static defaultProps = { | ||
| passRequiredToField: true, | ||
| }; | ||
|
|
||
| public state = { allowError: false }; | ||
|
|
||
| public componentDidMount() { | ||
| const { defaultValue, setValue } = this.props; | ||
| if (defaultValue) { | ||
| setValue(defaultValue); | ||
| } | ||
| } | ||
|
|
||
| public componentWillReceiveProps(nextProps: ComponentProps) { | ||
| if (nextProps.isFormSubmitted()) { | ||
| this.showError(); | ||
| } | ||
| } | ||
|
|
||
| public handleChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| const { value } = e.currentTarget; | ||
| this.props.setValue(value); | ||
| if (this.props.onChange) { | ||
|
Contributor
There was a problem hiding this comment. We're requiring the parent to provide a function for this prop - is it a best practice in TS to check if a variable is falsey even if it's required?
Contributor
Author
There was a problem hiding this comment. bad types on my part, they should be optional |
||
| this.props.onChange(e, e.currentTarget.value); | ||
| } | ||
| if (this.props.instantValidation) { | ||
| this.showError(); | ||
| } | ||
| }; | ||
|
|
||
| public handleBlur = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| this.showError(); | ||
| if (this.props.onBlur) { | ||
|
Contributor
There was a problem hiding this comment. Same question as in |
||
| this.props.onBlur(e, e.currentTarget.value); | ||
| } | ||
| }; | ||
|
|
||
| public showError = () => this.setState({ allowError: true }); | ||
|
|
||
| public render() { | ||
| const { | ||
| id, | ||
| required, | ||
| label, | ||
| getValue, | ||
| isValid, | ||
| isPristine, | ||
| getErrorMessage, | ||
| fullWidth, | ||
| className, | ||
| disabled, | ||
| helpText, | ||
| } = this.props; | ||
|
|
||
| const { allowError } = this.state; | ||
| const error = !isPristine() && !isValid() && allowError; | ||
|
|
||
| return ( | ||
| <EuiFormRow | ||
| id={id} | ||
| label={label} | ||
| helpText={helpText} | ||
| isInvalid={!disabled && error} | ||
| error={!disabled && error ? getErrorMessage() : []} | ||
| > | ||
| <EuiFieldText | ||
| id={id} | ||
| name={name} | ||
| value={getValue()} | ||
| isInvalid={!disabled && error} | ||
| onChange={this.handleChange} | ||
| onBlur={this.handleBlur} | ||
| fullWidth={fullWidth} | ||
| disabled={disabled} | ||
| required={required} | ||
| className={className} | ||
| /> | ||
| </EuiFormRow> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export const FormsyEuiFieldText = withFormsy(FieldText); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these optional - sorry, should have commented here before as well