review comments

Author: ywelsch

server/src/main/java/org/elasticsearch/cluster/coordination/Publication.java

@@ -180,12 +180,12 @@ enum PublicationTargetState {
         APPLIED_COMMIT,
     }
 
-    private class PublicationTarget {
+    class PublicationTarget {
         private final DiscoveryNode discoveryNode;
         private boolean ackIsPending = true;
         private PublicationTargetState state = PublicationTargetState.NOT_STARTED;
 
-        private PublicationTarget(DiscoveryNode discoveryNode) {
+        PublicationTarget(DiscoveryNode discoveryNode) {
             this.discoveryNode = discoveryNode;
         }
 

server/src/test/java/org/elasticsearch/cluster/coordination/PublicationTests.java

@@ -363,7 +363,8 @@ public void testClusterStatePublishingFailsOrTimesOutBeforeCommit() throws Inter
     }
 
     public void testClusterStatePublishingTimesOutAfterCommit() throws InterruptedException {
-        VotingConfiguration config = new VotingConfiguration(Sets.newHashSet(n1.getId(), n2.getId()));
+        VotingConfiguration config = new VotingConfiguration(randomBoolean() ?
+            Sets.newHashSet(n1.getId(), n2.getId()) : Sets.newHashSet(n1.getId(), n2.getId(), n3.getId()));
         initializeCluster(config);
 
         AssertingAckListener ackListener = new AssertingAckListener(nodes.size());