Fix wrong property mapping in SearchShard #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@gmarz I signed it, but only after I created the pull request, so I guess it didn't update... |
Contributor
|
@UdiBen Nope, found it. You signed with an e-mail address different than one in the commit. All good, thanks again! |
gmarz
added a commit
that referenced
this pull request
Dec 23, 2014
Fix wrong property mapping in SearchShard
Contributor
|
@UdiBen FYI after merging I realized this PR was pointed at the master branch rather than develop. I manually pushed it to develop as well. Not a big deal at all in this case because this fix will be included in the next release, but just so you know for future PRs- they should be from the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State was mapped to "name"