Skip to content

NonStringIndexOption should not default to No #1979

@gmarz

Description

@gmarz

We default the nullable argument for Index() on our property descriptors to No which doesn't make sense (for instance here and here).

The default in ES is to index, so calling Index() without passing No does the opposite of what you expect.

We should deprecate this in 2.x and remove it the method completely in 5.x. I think something along the lines of NotIndexed() (can't think of a better name at the moment) makes more sense, similar to how we have NotAnalyzed().

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions